diff --git a/CHANGELOG.md b/CHANGELOG.md index b80c258..c23a0e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] +### Changed + - Workaround for logged XML format exceptions when failing to parse floats + ## [8.9.2] - 2020-07-28 ### Changed - StringExtensions - fixed an issue with IsNumeric where empty strings would return true diff --git a/ICD.Common.Utils/Xml/IcdXmlReader.cs b/ICD.Common.Utils/Xml/IcdXmlReader.cs index 18e2af1..86d25ec 100644 --- a/ICD.Common.Utils/Xml/IcdXmlReader.cs +++ b/ICD.Common.Utils/Xml/IcdXmlReader.cs @@ -177,26 +177,16 @@ namespace ICD.Common.Utils.Xml public long ReadElementContentAsLong() { - try - { - return m_Reader.ReadElementContentAsLong(); - } - catch (XmlException e) - { - throw new IcdXmlException(e); - } + // ReadElementContentAsLong() logs and throws... + string value = ReadElementContentAsString(); + return long.Parse(value); } public float ReadElementContentAsFloat() { - try - { - return m_Reader.ReadElementContentAsFloat(); - } - catch (XmlException e) - { - throw new IcdXmlException(e); - } + // ReadElementContentAsFloat() logs and throws... + string value = ReadElementContentAsString(); + return float.Parse(value); } public bool ReadElementContentAsBoolean()