icdsystems/ICD.Common.Utils
1
0
Fork 0
mirror of https://github.com/ICDSystems/ICD.Common.Utils.git synced 2026-02-16 13:15:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: ReprBuilder micro-optimizations

Browse Source
This commit is contained in:
Chris Cameron
2019-02-06 17:09:37 -05:00
parent ffe3e67241
commit be6a6de65a
1 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
ICD.Common.Utils/ReprBuilder.cs
View File

@@ -12,8 +12,7 @@ namespace ICD.Common.Utils
{ {
private readonly object m_Instance; private readonly object m_Instance;
private readonly List<string> m_PropertyOrder; private readonly List<KeyValuePair<string, string>> m_PropertyOrder;
private readonly Dictionary<string, string> m_PropertyValues;
/// <summary> /// <summary>
/// Constructor. /// Constructor.
@@ -23,8 +22,7 @@ namespace ICD.Common.Utils
{ {
m_Instance = instance; m_Instance = instance;
m_PropertyOrder = new List<string>(); m_PropertyOrder = new List<KeyValuePair<string, string>>();
m_PropertyValues = new Dictionary<string, string>();
} }
/// <summary> /// <summary>
@@ -45,11 +43,7 @@ namespace ICD.Common.Utils
/// <param name="value"></param> /// <param name="value"></param>
public ReprBuilder AppendPropertyRaw(string name, string value) public ReprBuilder AppendPropertyRaw(string name, string value)
{ {
m_PropertyOrder.Remove(name); m_PropertyOrder.Add(new KeyValuePair<string, string>(name, value));
m_PropertyOrder.Add(name);
m_PropertyValues[name] = value;
return this; return this;
} }
@@ -60,7 +54,7 @@ namespace ICD.Common.Utils
public override string ToString() public override string ToString()
{ {
if (m_Instance == null) if (m_Instance == null)
return GetValueStringRepresentation(m_Instance); return GetValueStringRepresentation(null);
StringBuilder builder = new StringBuilder(); StringBuilder builder = new StringBuilder();
@@ -69,12 +63,11 @@ namespace ICD.Common.Utils
for (int index = 0; index < m_PropertyOrder.Count; index++) for (int index = 0; index < m_PropertyOrder.Count; index++)
{ {
string property = m_PropertyOrder[index]; KeyValuePair<string, string> pair = m_PropertyOrder[index];
builder.Append(property);
builder.Append('=');
string valueString = m_PropertyValues[property]; builder.Append(pair.Key);
builder.Append(valueString); builder.Append('=');
builder.Append(pair.Value);
if (index < m_PropertyOrder.Count - 1) if (index < m_PropertyOrder.Count - 1)
builder.Append(", "); builder.Append(", ");