icdsystems/ICD.Common.Utils
1
0
Fork 0
mirror of https://github.com/ICDSystems/ICD.Common.Utils.git synced 2026-01-11 19:44:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor[BigEndianBitConverter]: Reduce code reuse in GetBytes methods

Browse Source
This commit is contained in:
Drew Tingen
2023-06-18 09:52:18 -04:00
parent 138a6f3470
commit c6b6711eb2
1 changed files with 3 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
ICD.Common.Utils/BigEndianBitConverter.cs
View File

@@ -101,17 +101,7 @@ namespace ICD.Common.Utils
} }
public static byte[] GetBytes(uint value) public static byte[] GetBytes(uint value)
{ {
if (!BitConverter.IsLittleEndian) return unchecked(GetBytes((int)value));
return BitConverter.GetBytes(value);
const int total_bytes = sizeof(uint);
byte[] response = new byte[total_bytes];
for (int i = 0; i < total_bytes; i++)
response[i] = (byte)(value >> GetBitShift(i,total_bytes) & FULL_BYTE);
return response;
} }
public static byte[] GetBytes(short value) public static byte[] GetBytes(short value)
@@ -131,17 +121,7 @@ namespace ICD.Common.Utils
public static byte[] GetBytes(ushort value) public static byte[] GetBytes(ushort value)
{ {
if (!BitConverter.IsLittleEndian) return unchecked(GetBytes((short)value));
return BitConverter.GetBytes(value);
const int total_bytes = sizeof(short);
byte[] response = new byte[total_bytes];
for (int i = 0; i < total_bytes; i++)
response[i] = (byte)(value >> GetBitShift(i,total_bytes) & FULL_BYTE);
return response;
} }
public static byte[] GetBytes(long value) public static byte[] GetBytes(long value)
@@ -161,17 +141,7 @@ namespace ICD.Common.Utils
public static byte[] GetBytes(ulong value) public static byte[] GetBytes(ulong value)
{ {
if (!BitConverter.IsLittleEndian) return unchecked(GetBytes((long)value));
return BitConverter.GetBytes(value);
const int total_bytes = sizeof(ulong);
byte[] response = new byte[total_bytes];
for (int i = 0; i < total_bytes; i++)
response[i] = (byte)(value >> GetBitShift(i,total_bytes) & FULL_BYTE);
return response;
} }
private static int GetBitShift(int byteNumber, int totalBytes) private static int GetBitShift(int byteNumber, int totalBytes)
{ {