refactor: Tidying

This commit is contained in:
Chris Cameron
2018-10-29 10:36:44 -04:00
parent 5cec0e10f1
commit e44a18b111

View File

@@ -133,7 +133,7 @@ namespace ICD.Common.Utils.Collections
IcdHashSet<T> intersectionSet = new IcdHashSet<T>(); IcdHashSet<T> intersectionSet = new IcdHashSet<T>();
foreach (T item in set.Where(item => Contains(item))) foreach (T item in set.Where(Contains))
intersectionSet.Add(item); intersectionSet.Add(item);
return intersectionSet; return intersectionSet;
@@ -230,12 +230,12 @@ namespace ICD.Common.Utils.Collections
if (set == null) if (set == null)
return Count == 0; return Count == 0;
return Count == set.Count && set.All(item => Contains(item)); return Count == set.Count && set.All(Contains);
} }
#endregion #endregion
#region ICollection<T> Members #region ICollection<T>
/// <summary> /// <summary>
/// Adds the item to the collection. Returns false if the item already exists. /// Adds the item to the collection. Returns false if the item already exists.
@@ -244,7 +244,9 @@ namespace ICD.Common.Utils.Collections
/// <returns></returns> /// <returns></returns>
public bool Add(T item) public bool Add(T item)
{ {
// ReSharper disable CompareNonConstrainedGenericWithNull
if (item == null) if (item == null)
// ReSharper restore CompareNonConstrainedGenericWithNull
throw new ArgumentNullException("item"); throw new ArgumentNullException("item");
if (m_Dict.ContainsKey(item)) if (m_Dict.ContainsKey(item))
@@ -292,7 +294,9 @@ namespace ICD.Common.Utils.Collections
/// <returns></returns> /// <returns></returns>
public bool Contains(T item) public bool Contains(T item)
{ {
// ReSharper disable CompareNonConstrainedGenericWithNull
if (item == null) if (item == null)
// ReSharper restore CompareNonConstrainedGenericWithNull
throw new ArgumentNullException("item"); throw new ArgumentNullException("item");
return m_Dict.ContainsKey(item); return m_Dict.ContainsKey(item);
@@ -316,7 +320,9 @@ namespace ICD.Common.Utils.Collections
/// <param name="item">The object to remove from the <see cref="T:System.Collections.Generic.ICollection`1"/>.</param><exception cref="T:System.NotSupportedException">The <see cref="T:System.Collections.Generic.ICollection`1"/> is read-only.</exception> /// <param name="item">The object to remove from the <see cref="T:System.Collections.Generic.ICollection`1"/>.</param><exception cref="T:System.NotSupportedException">The <see cref="T:System.Collections.Generic.ICollection`1"/> is read-only.</exception>
public bool Remove(T item) public bool Remove(T item)
{ {
// ReSharper disable CompareNonConstrainedGenericWithNull
if (item == null) if (item == null)
// ReSharper restore CompareNonConstrainedGenericWithNull
throw new ArgumentNullException("item"); throw new ArgumentNullException("item");
return m_Dict.Remove(item); return m_Dict.Remove(item);
@@ -324,7 +330,7 @@ namespace ICD.Common.Utils.Collections
#endregion #endregion
#region Implementation of IEnumerable #region IEnumerable<T>
/// <summary> /// <summary>
/// Returns an enumerator that iterates through the collection. /// Returns an enumerator that iterates through the collection.