icdsystems/ICD.Common.Utils
1
0
Fork 0
mirror of https://github.com/ICDSystems/ICD.Common.Utils.git synced 2026-02-16 13:15:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Enumerate over XML attributes

Browse Source
This commit is contained in:
Chris Cameron
2018-11-08 15:50:12 -05:00
parent e0176741d2
commit f53607018c
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ICD.Common.Utils/Xml/XmlReaderExtensions.cs
View File

@@ -42,17 +42,11 @@ namespace ICD.Common.Utils.Xml
if (extends == null) if (extends == null)
throw new ArgumentNullException("extends"); throw new ArgumentNullException("extends");
if (!extends.HasAttributes)
return Enumerable.Empty<IcdXmlAttribute>();
List<IcdXmlAttribute> attributes = new List<IcdXmlAttribute>();
while (extends.MoveToNextAttribute()) while (extends.MoveToNextAttribute())
attributes.Add(new IcdXmlAttribute(extends.Name, extends.Value)); yield return new IcdXmlAttribute(extends.Name, extends.Value);
// Move back to element. // Move back to element.
extends.MoveToElement(); extends.MoveToElement();
return attributes.ToArray();
} }
/// <summary> /// <summary>

2
ICD.Common.Utils/Xml/XmlUtils.cs
View File

@@ -60,7 +60,7 @@ namespace ICD.Common.Utils.Xml
using (IcdXmlReader reader = new IcdXmlReader(xml)) using (IcdXmlReader reader = new IcdXmlReader(xml))
{ {
reader.ReadToNextElement(); reader.ReadToNextElement();
return reader.GetAttributes(); return reader.GetAttributes().ToArray();
} }
} }