pepperdash/Essentials
1
0
Fork 0
mirror of https://github.com/PepperDash/Essentials.git synced 2026-01-11 19:44:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: streamline ComPort registration and configuration logic with enhanced logging

Browse Source
This commit is contained in:
jkdevito
2025-10-27 17:13:43 -05:00
parent 89e893b3b7
commit 151a90c9be
1 changed files with 40 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
src/PepperDash.Essentials.Core/Comm and IR/ComPortController.cs
View File

@@ -73,56 +73,56 @@ namespace PepperDash.Essentials.Core
Debug.LogMessage(LogEventLevel.Information, this, "Configured com Port for this device does not exist."); Debug.LogMessage(LogEventLevel.Information, this, "Configured com Port for this device does not exist.");
return; return;
} }
if (Port.Parent is CrestronControlSystem || Port.Parent is CenIoCom102) // TODO [ ] - Verify nothing blows up without the `if` check
//if (Port.Parent is CrestronControlSystem || Port.Parent is CenIoCom102)
//{
var result = Port.Register();
if (result != eDeviceRegistrationUnRegistrationResponse.Success)
{ {
var result = Port.Register(); Debug.LogMessage(LogEventLevel.Information, this, "ERROR: Cannot register Com port: {0}", result);
if (result != eDeviceRegistrationUnRegistrationResponse.Success) return; // false
{
Debug.LogMessage(LogEventLevel.Information, this, "ERROR: Cannot register Com port: {0}", result);
return; // false
}
} }
//}
var specResult = Port.SetComPortSpec(Spec); var specResult = Port.SetComPortSpec(Spec);
if (specResult != 0) if (specResult != 0)
{ {
Debug.LogMessage(LogEventLevel.Information, this, "WARNING: Cannot set comspec"); this.LogInformation("WARNING: Cannot set comspec");
return; return;
} }
this.LogDebug($"ComPort comspec successfully set (specResult == {specResult})");
//this.LogInformation($"RegisterAndConfigureComPort: Port.Parent-'{Port.Parent}', Port.ParentDevice-'{Port.ParentDevice}'");
// if (Port.Parent is CenIoCom102)
// {
// this.LogInformation($"RegisterAndConfigureComPort: ");
// Port.Register();
// Port.PropertyChanged += (s, e) =>
// {
// this.LogInformation($"RegisterAndConfigureComPort: PropertyChanged Fired >> comPort-'{Port.ID}', Property Changed-'{e.Property}', Value Changed-'{e.Value}'");
// this.LogInformation($"RegisterAndConfigureComPort: deviceName-'{Port.DeviceName}', parentDevice-'{Port.ParentDevice}', parent-`{Port.Parent}`, online-`{Port.IsOnline}`, preset-`{Port.Present}`, supportedBaudRates-'{Port.SupportedBaudRates}'");
// };
// Port.ExtendedInformationChanged += (s, e) =>
// {
// this.LogInformation($@"RegisterAndConfigureComPort: ExtendedInformationChanged Fired >> comPort-'{Port.ID}', {e.Protocol} using `
// {e.BaudRate},
// {e.Parity},
// {e.DataBits},
// {e.StopBits},
// HW Handshake-'{e.HardwareHandshakeSetting}',
// SW Handshake-'{e.SoftwareHandshakeSetting}'");
// };
// this.LogInformation($@"RegisterAndConfigureComPort: Configuring comPort-'{Port.ID}' using Spec
// {Spec.BaudRate},
// {Spec.DataBits},
// {Spec.Parity},
// {Spec.StopBits},
// HW Handshake-'{Spec.HardwareHandShake}',
// SW Handshake-'{Spec.SoftwareHandshake}'");
// } // TODO [ ] - Remove debug logging once verified working
if (Port.Parent is CenIoCom102)
{
Port.PropertyChanged += (s, e) =>
{
this.LogInformation($@"RegisterAndConfigureComPort: PropertyChanged Fired >>
comPort-'{Port.ID}',
Property Changed-'{e.Property}',
Value Changed-'{e.Value}',
deviceName-'{Port.DeviceName}',
parentDevice-'{Port.ParentDevice}',
parent-`{Port.Parent}`,
online-`{Port.IsOnline}`,
present-`{Port.Present}`,
supportedBaudRates-'{Port.SupportedBaudRates}'");
};
Port.ExtendedInformationChanged += (s, e) =>
{
this.LogInformation($@"RegisterAndConfigureComPort: ExtendedInformationChanged Fired >>
comPort-'{Port.ID}',
{e.Protocol},
{e.BaudRate},
{e.Parity},
{e.DataBits},
{e.StopBits},
HW Handshake-'{e.HardwareHandshakeSetting}',
SW Handshake-'{e.SoftwareHandshakeSetting}'");
};
}
Port.SerialDataReceived += Port_SerialDataReceived; Port.SerialDataReceived += Port_SerialDataReceived;
} }