pepperdash/Essentials
1
0
Fork 0
mirror of https://github.com/PepperDash/Essentials.git synced 2026-07-02 10:38:16 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: remove ComPortController finalizer and harden deactivate cleanup

Browse source
This commit is contained in:
copilot-swe-agent[bot] 2026-06-05 20:43:52 +00:00 • committed by GitHub
parent cffcfbbda1
commit 1681d4e796
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/PepperDash.Essentials.Core/Comm and IR/ComPortController.cs
View file

@ -114,17 +114,6 @@ namespace PepperDash.Essentials.Core
Port.SerialDataReceived += Port_SerialDataReceived; Port.SerialDataReceived += Port_SerialDataReceived;
} }
/// <summary>
/// Destructor
/// </summary>
~ComPortController()
{
if (Port == null)
return;
Port.SerialDataReceived -= Port_SerialDataReceived;
}
void Port_SerialDataReceived(ComPort ReceivingComPort, ComPortSerialDataEventArgs args) void Port_SerialDataReceived(ComPort ReceivingComPort, ComPortSerialDataEventArgs args)
{ {
OnDataReceived(args.SerialData); OnDataReceived(args.SerialData);
@ -162,6 +151,7 @@ namespace PepperDash.Essentials.Core
if (Port == null) if (Port == null)
return false; return false;
Port.SerialDataReceived -= Port_SerialDataReceived;
return Port.UnRegister() == eDeviceRegistrationUnRegistrationResponse.Success; return Port.UnRegister() == eDeviceRegistrationUnRegistrationResponse.Success;
} }