From c557400f383b5c5450c856c5baef93e1c2fd4a69 Mon Sep 17 00:00:00 2001 From: Neil Dorin Date: Fri, 26 Aug 2022 15:07:57 -0600 Subject: [PATCH 1/2] fix(essentials): updates ZoomRoom mute state to report muted when not in call --- .../VideoCodec/VideoCodecBase.cs | 2 ++ .../VideoCodec/ZoomRoom/ZoomRoom.cs | 18 +++++++++++++++++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/VideoCodecBase.cs b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/VideoCodecBase.cs index 6e577c59..1270b690 100644 --- a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/VideoCodecBase.cs +++ b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/VideoCodecBase.cs @@ -214,6 +214,8 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec handler(this, new CodecCallStatusItemChangeEventArgs(item)); } + PrivacyModeIsOnFeedback.FireUpdate(); + if (AutoShareContentWhileInCall) { StartSharing(); diff --git a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs index 32415d1d..a8b413a8 100644 --- a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs +++ b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs @@ -214,7 +214,23 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom protected override Func PrivacyModeIsOnFeedbackFunc { - get { return () => Configuration.Call.Microphone.Mute; } + get + { + return () => + { + Debug.Console(2, this, "PrivacyModeIsOnFeedbackFunc. IsInCall: {0} muteState: {1}", IsInCall, Configuration.Call.Microphone.Mute); + if (IsInCall) + { + Debug.Console(2, this, "reporting muteState: ", Configuration.Call.Microphone.Mute); + return Configuration.Call.Microphone.Mute; + } + else + { + Debug.Console(2, this, "muteState: true", IsInCall); + return true; + } + }; + } } protected override Func StandbyIsOnFeedbackFunc From 215cf6696e379c15222a512d54d98c06e159857b Mon Sep 17 00:00:00 2001 From: Neil Dorin Date: Thu, 8 Sep 2022 14:22:53 -0600 Subject: [PATCH 2/2] fix(essentials): Set not in call state to report as unmuted --- .../VideoCodec/ZoomRoom/ZoomRoom.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs index a8b413a8..d3c0cd0f 100644 --- a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs +++ b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs @@ -218,16 +218,16 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom { return () => { - Debug.Console(2, this, "PrivacyModeIsOnFeedbackFunc. IsInCall: {0} muteState: {1}", IsInCall, Configuration.Call.Microphone.Mute); + //Debug.Console(2, this, "PrivacyModeIsOnFeedbackFunc. IsInCall: {0} muteState: {1}", IsInCall, Configuration.Call.Microphone.Mute); if (IsInCall) { - Debug.Console(2, this, "reporting muteState: ", Configuration.Call.Microphone.Mute); + //Debug.Console(2, this, "reporting muteState: ", Configuration.Call.Microphone.Mute); return Configuration.Call.Microphone.Mute; } else { - Debug.Console(2, this, "muteState: true", IsInCall); - return true; + //Debug.Console(2, this, "muteState: true", IsInCall); + return false; } }; }