From 4058040330efcde65fbb271a45dbaa60ff551027 Mon Sep 17 00:00:00 2001 From: anthony-lopez-pd Date: Tue, 9 Jun 2026 16:20:58 -0400 Subject: [PATCH] fix: remove dead DirectoryLineSelected join; fix SelfviewPositionFb description MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DirectoryLineSelected (digital 101, FromSIMPL) had no handler anywhere in VideoCodecBase.cs — directory selection is driven by analog 101 (DirectorySelectRow). DirectoryEntryIsContact (ToSIMPL) already documents the output side of that join. Removed the dead inbound entry. SelfviewPositionFb (serial 211) description "advance selfview position" read like a command; updated to "Current selfview PIP position string FB" to accurately reflect that it is a ToSIMPL feedback. Co-Authored-By: Claude Sonnet 4.6 --- .../JoinMaps/VideoCodecControllerJoinMap.cs | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/PepperDash.Essentials.Core/Bridges/JoinMaps/VideoCodecControllerJoinMap.cs b/src/PepperDash.Essentials.Core/Bridges/JoinMaps/VideoCodecControllerJoinMap.cs index ac494a5f..9c434cab 100644 --- a/src/PepperDash.Essentials.Core/Bridges/JoinMaps/VideoCodecControllerJoinMap.cs +++ b/src/PepperDash.Essentials.Core/Bridges/JoinMaps/VideoCodecControllerJoinMap.cs @@ -442,22 +442,6 @@ namespace PepperDash.Essentials.Core.Bridges.JoinMaps; JoinType = eJoinType.Digital }); - /// - /// Directory Line Selected - /// - [JoinName("DirectoryLineSelected")] - public JoinDataComplete DirectoryLineSelected = new JoinDataComplete( - new JoinData - { - JoinNumber = 101, - JoinSpan = 1 - }, - new JoinMetadata - { - Description = "Directory Line Selected FB", - JoinCapabilities = eJoinCapabilities.FromSIMPL, - JoinType = eJoinType.Digital - }); /// /// Directory Is Root @@ -1873,7 +1857,7 @@ namespace PepperDash.Essentials.Core.Bridges.JoinMaps; }, new JoinMetadata { - Description = "advance selfview position", + Description = "Current selfview PIP position string FB", JoinCapabilities = eJoinCapabilities.ToSIMPL, JoinType = eJoinType.Serial });