pepperdash/Essentials
1
0
Fork 0
mirror of https://github.com/PepperDash/Essentials.git synced 2026-02-16 13:15:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improve logging messages in ComPort registration and configuration

Browse Source
This commit is contained in:
jkdevito
2025-10-28 09:04:15 -05:00
parent c4d064965f
commit 92c9db8237
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/PepperDash.Essentials.Core/Comm and IR/ComPortController.cs
View File

@@ -97,11 +97,11 @@ namespace PepperDash.Essentials.Core
//if (Port.Parent is CrestronControlSystem || Port.Parent is CenIoCom102) //if (Port.Parent is CrestronControlSystem || Port.Parent is CenIoCom102)
if (Port.Parent is GenericBase genericDevice && genericDevice.Registerable) if (Port.Parent is GenericBase genericDevice && genericDevice.Registerable)
{ {
this.LogInformation($"INFO: Attempting to register {Port.Parent.GetType().Name}-comport-{Port.ID} using GenericBase"); //this.LogInformation($"INFO: Attempting to register {Key} using {Port.Parent.GetType().Name}-comport-{Port.ID}");
var result = genericDevice.Register(); var result = genericDevice.Register();
if (result != eDeviceRegistrationUnRegistrationResponse.Success) if (result != eDeviceRegistrationUnRegistrationResponse.Success)
{ {
this.LogError($"ERROR: Cannot register comport: {result}"); this.LogError($"ERROR: Cannot register {Key} using {Port.Parent.GetType().Name}-comport-{Port.ID} (result == {result})");
return; // false return; // false
} }
} }
@@ -109,10 +109,10 @@ namespace PepperDash.Essentials.Core
var specResult = Port.SetComPortSpec(Spec); var specResult = Port.SetComPortSpec(Spec);
if (specResult != 0) if (specResult != 0)
{ {
this.LogError("ERROR: Cannot set comspec"); this.LogError($"ERROR: Cannot set comspec for {Key} using {Port.Parent.GetType().Name}-comport-{Port.ID} (result == {specResult})");
return; return;
} }
this.LogInformation($"INFO: Comspec successfully set (result == {specResult})"); //this.LogInformation($"INFO: Successfully set comspec for {Key} using {Port.Parent.GetType().Name}-comport-{Port.ID} (result == {specResult})");
// TODO [ ] - Remove debug logging once verified working // TODO [ ] - Remove debug logging once verified working