pepperdash/Essentials
1
0
Fork 0
mirror of https://github.com/PepperDash/Essentials.git synced 2026-01-11 19:44:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: copilot suggestions from PR review

Browse Source
This commit is contained in:
Andrew Welker
2025-11-03 11:02:39 -06:00
parent 0d083e63c6
commit 9426dff5df
4 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/PepperDash.Core/Comm/GenericSshClient.cs
View File

@@ -278,7 +278,7 @@ namespace PepperDash.Core
if (shellStream.DataAvailable) if (shellStream.DataAvailable)
{ {
// empty the buffer if there is data // empty the buffer if there is data
string str = shellStream.Read(); shellStream.Read();
} }
shellStream.DataReceived += Stream_DataReceived; shellStream.DataReceived += Stream_DataReceived;
this.LogInformation("Connected"); this.LogInformation("Connected");
@@ -287,8 +287,7 @@ namespace PepperDash.Core
} }
catch (SshConnectionException e) catch (SshConnectionException e)
{ {
var ie = e.InnerException; // The details are inside!! var ie = e.InnerException; // The details are inside!!
var errorLogLevel = disconnectLogged == true ? Debug.ErrorLogLevel.None : Debug.ErrorLogLevel.Error;
if (ie is SocketException) if (ie is SocketException)
{ {
@@ -335,7 +334,6 @@ namespace PepperDash.Core
} }
catch (Exception e) catch (Exception e)
{ {
var errorLogLevel = disconnectLogged == true ? Debug.ErrorLogLevel.None : Debug.ErrorLogLevel.Error;
this.LogError("Unhandled exception on connect: {error}", e.Message); this.LogError("Unhandled exception on connect: {error}", e.Message);
this.LogVerbose(e, "Exception details: "); this.LogVerbose(e, "Exception details: ");
disconnectLogged = true; disconnectLogged = true;
@@ -518,7 +516,7 @@ namespace PepperDash.Core
this.LogError("ObjectDisposedException sending '{message}'. Restarting connection...", text.Trim()); this.LogError("ObjectDisposedException sending '{message}'. Restarting connection...", text.Trim());
KillClient(SocketStatus.SOCKET_STATUS_CONNECT_FAILED); KillClient(SocketStatus.SOCKET_STATUS_CONNECT_FAILED);
StopReconnectTimer(); StartReconnectTimer();
} }
catch (Exception ex) catch (Exception ex)
{ {
@@ -551,7 +549,7 @@ namespace PepperDash.Core
this.LogException(ex, "ObjectDisposedException sending {message}", ComTextHelper.GetEscapedText(bytes)); this.LogException(ex, "ObjectDisposedException sending {message}", ComTextHelper.GetEscapedText(bytes));
KillClient(SocketStatus.SOCKET_STATUS_CONNECT_FAILED); KillClient(SocketStatus.SOCKET_STATUS_CONNECT_FAILED);
StopReconnectTimer(); StartReconnectTimer();
} }
catch (Exception ex) catch (Exception ex)
{ {

3
src/PepperDash.Core/Comm/GenericTcpIpClient.cs
View File

@@ -477,8 +477,7 @@ namespace PepperDash.Core
/// </summary> /// </summary>
public void SendBytes(byte[] bytes) public void SendBytes(byte[] bytes)
{ {
if (StreamDebugging.TxStreamDebuggingIsEnabled) this.PrintSentBytes(bytes);
Debug.Console(0, this, "Sending {0} bytes: '{1}'", bytes.Length, ComTextHelper.GetEscapedText(bytes));
if (_client != null) if (_client != null)
_client.SendData(bytes, bytes.Length); _client.SendData(bytes, bytes.Length);
} }

0
src/PepperDash.Core/Comm/StreamDebuggingExtensionMethods.cs → src/PepperDash.Core/Comm/StreamDebuggingExtensions.cs
View File

2
src/PepperDash.Core/Comm/eStreamDebuggingDataTypeSettings.cs
View File

@@ -19,6 +19,6 @@ namespace PepperDash.Core
/// <summary> /// <summary>
/// Debug data in both byte and text formats /// Debug data in both byte and text formats
/// </summary> /// </summary>
Both = Bytes | Text, Both = Bytes | Text
} }
} }