pepperdash/Essentials
1
0
Fork 0
mirror of https://github.com/PepperDash/Essentials.git synced 2026-02-15 20:54:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: removed property sets as recommended in discussion; removed 'if' statements before property sets in leave and end call methods

Browse Source
This commit is contained in:
jdevito
2022-10-28 16:20:49 -05:00
parent 4d6da37c60
commit a09212417c
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs
View File

@@ -2583,7 +2583,6 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom
if (args.LoginAttemptCancelled) if (args.LoginAttemptCancelled)
{ {
trilist.SetBool(joinMap.MeetingPasswordRequired.JoinNumber, false); trilist.SetBool(joinMap.MeetingPasswordRequired.JoinNumber, false);
_meetingPasswordRequired = false;
return; return;
} }
@@ -2595,7 +2594,6 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom
if (args.LoginAttemptFailed) if (args.LoginAttemptFailed)
{ {
// login attempt failed // login attempt failed
_meetingPasswordRequired = false;
return; return;
} }
@@ -2820,24 +2818,24 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom
public void LeaveMeeting() public void LeaveMeeting()
{ {
if (_meetingPasswordRequired) _meetingPasswordRequired = false; _meetingPasswordRequired = false;
if (_waitingForUserToAcceptOrRejectIncomingCall) _waitingForUserToAcceptOrRejectIncomingCall = false; _waitingForUserToAcceptOrRejectIncomingCall = false;
SendText("zCommand Call Leave"); SendText("zCommand Call Leave");
} }
public override void EndCall(CodecActiveCallItem call) public override void EndCall(CodecActiveCallItem call)
{ {
if (_meetingPasswordRequired) _meetingPasswordRequired = false; _meetingPasswordRequired = false;
if (_waitingForUserToAcceptOrRejectIncomingCall) _waitingForUserToAcceptOrRejectIncomingCall = false; _waitingForUserToAcceptOrRejectIncomingCall = false;
SendText("zCommand Call Disconnect"); SendText("zCommand Call Disconnect");
} }
public override void EndAllCalls() public override void EndAllCalls()
{ {
if (_meetingPasswordRequired) _meetingPasswordRequired = false; _meetingPasswordRequired = false;
if (_waitingForUserToAcceptOrRejectIncomingCall) _waitingForUserToAcceptOrRejectIncomingCall = false; _waitingForUserToAcceptOrRejectIncomingCall = false;
SendText("zCommand Call Disconnect"); SendText("zCommand Call Disconnect");
} }