pepperdash/Essentials
1
0
Fork 0
mirror of https://github.com/PepperDash/Essentials.git synced 2026-04-14 13:07:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1211 from PepperDash/hotfix-2.0.0/room-combiner-syncronous-events

Browse source 
fix: improve error handling and await device actions in RoomCombinati…
This commit is contained in:
Andrew Welker 2025-02-19 17:20:59 -06:00 • committed by GitHub
commit b2eab21fbd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/PepperDash.Essentials.Core/Room/Combining/RoomCombinationScenario.cs
View file

@ -81,12 +81,10 @@ namespace PepperDash.Essentials.Core
foreach (var action in activationActions)
{
this.LogInformation("Running Activation action {@action}", action);
tasks.Add(DeviceJsonApi.DoDeviceActionAsync(action));
await DeviceJsonApi.DoDeviceActionAsync(action);
}
}
await Task.WhenAll(tasks);
IsActive = true;
}
@ -101,12 +99,10 @@ namespace PepperDash.Essentials.Core
foreach (var action in deactivationActions)
{
this.LogInformation("Running deactivation action {actionDeviceKey}:{actionMethod}", action.DeviceKey, action.MethodName);
tasks.Add( DeviceJsonApi.DoDeviceActionAsync(action));
await DeviceJsonApi.DoDeviceActionAsync(action);
}
}
await Task.WhenAll(tasks);
IsActive = false;
}