From eae089cdf58e20d806ac4ac46126a7d938e9022a Mon Sep 17 00:00:00 2001 From: Neil Dorin Date: Thu, 22 Sep 2022 15:38:11 -0600 Subject: [PATCH] fix(essentials): updates to password prompt logic --- .../VideoCodec/ZoomRoom/ZoomRoom.cs | 10 +++++----- .../VideoCodec/ZoomRoom/ZoomRoomJoinMap.cs | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs index b753b3fc..5aeb3be0 100644 --- a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs +++ b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs @@ -2513,14 +2513,14 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom // Subscribe to call status to clear ShowPasswordPrompt when in meeting this.CallStatusChange += (o, a) => { - if (IsInCall) + if (a.CallItem.Status == eCodecCallStatus.Connected || a.CallItem.Status == eCodecCallStatus.Disconnected) { - trilist.SetBool(joinMap.ShowPasswordPrompt.JoinNumber, false); + trilist.SetBool(joinMap.MeetingPasswordRequired.JoinNumber, false); } }; - trilist.SetSigFalseAction(joinMap.CancelPasswordPrompt.JoinNumber, () => CancelPasswordPrompt()); + trilist.SetSigFalseAction(joinMap.CancelJoinAttempt.JoinNumber, () => trilist.SetBool(joinMap.MeetingPasswordRequired.JoinNumber, false)); PasswordRequired += (devices, args) => { @@ -2528,7 +2528,7 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom if (args.LoginAttemptCancelled) { - trilist.SetBool(joinMap.ShowPasswordPrompt.JoinNumber, false); + trilist.SetBool(joinMap.MeetingPasswordRequired.JoinNumber, false); return; } @@ -2544,7 +2544,7 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom } trilist.SetBool(joinMap.PasswordIncorrect.JoinNumber, args.LastAttemptWasIncorrect); - trilist.SetBool(joinMap.ShowPasswordPrompt.JoinNumber, true); + trilist.SetBool(joinMap.MeetingPasswordRequired.JoinNumber, true); }; trilist.OnlineStatusChange += (device, args) => diff --git a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoomJoinMap.cs b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoomJoinMap.cs index d6ffb903..c377a664 100644 --- a/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoomJoinMap.cs +++ b/essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoomJoinMap.cs @@ -8,8 +8,8 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom { #region Digital - [JoinName("CancelPasswordPrompt")] - public JoinDataComplete CancelPasswordPrompt = new JoinDataComplete( + [JoinName("CancelJoinAttempt")] + public JoinDataComplete CancelJoinAttempt = new JoinDataComplete( new JoinData { JoinNumber = 5, @@ -22,8 +22,8 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom JoinType = eJoinType.Digital }); - [JoinName("ShowPasswordPrompt")] - public JoinDataComplete ShowPasswordPrompt = new JoinDataComplete( + [JoinName("MeetingPasswordRequired")] + public JoinDataComplete MeetingPasswordRequired = new JoinDataComplete( new JoinData { JoinNumber = 6,