pepperdash/Essentials
1
0
Fork 0
mirror of https://github.com/PepperDash/Essentials.git synced 2026-08-31 19:08:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

feat: update RoutingFeedbackManager to use ConcurrentDictionary for update timers to ensure thread safety

Browse source
This commit is contained in:
Neil Dorin 2026-07-14 21:47:52 -06:00
parent 079f2beb8b
commit f05a25c3e2
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/PepperDash.Essentials.Core/Routing/RoutingFeedbackManager.cs
View file

@ -1,4 +1,5 @@
using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Linq;
using System.Timers;
@ -22,9 +23,13 @@ namespace PepperDash.Essentials.Core.Routing
private Dictionary<string, HashSet<RoutingInputPort>> midpointToSinkInputsMap;
/// <summary>
/// Debounce timers for each sink device to prevent rapid successive updates
/// Debounce timers for each sink device to prevent rapid successive updates. Must be a
/// ConcurrentDictionary - it's mutated both from whatever thread calls UpdateDestination and
/// from each Timer's Elapsed callback (which fires on a threadpool timer thread), so a plain
/// Dictionary here would have its internal state corrupted by the concurrent Insert/Remove
/// calls, surfacing as an IndexOutOfRangeException from deep inside Dictionary internals.
/// </summary>
private readonly Dictionary<string, Timer> updateTimers = new Dictionary<string, Timer>();
private readonly ConcurrentDictionary<string, Timer> updateTimers = new ConcurrentDictionary<string, Timer>();
/// <summary>
/// Debounce delay in milliseconds
@ -314,10 +319,9 @@ namespace PepperDash.Essentials.Core.Routing
}
finally
{
if (updateTimers.ContainsKey(key))
if (updateTimers.TryRemove(key, out var timerToDispose))
{
updateTimers[key]?.Dispose();
updateTimers.Remove(key);
timerToDispose?.Dispose();
}
}
};