pepperdash/Essentials
1
0
Fork 0
mirror of https://github.com/PepperDash/Essentials.git synced 2026-04-12 12:06:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #907 from PepperDash/feature/refine-zoomroom-addedcontact-feedback-subscription

Browse source 
fix(essentials): #901 Refines initial synchronization sequence
This commit is contained in:
Neil Dorin 2022-02-15 15:52:14 -07:00 • committed by GitHub
commit f3431f287c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

19
essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/ZoomRoom/ZoomRoom.cs
View file

@ -102,6 +102,8 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom
PhonebookSyncState = new CodecPhonebookSyncState(Key + "--PhonebookSync"); PhonebookSyncState = new CodecPhonebookSyncState(Key + "--PhonebookSync");
PhonebookSyncState.InitialSyncCompleted += (o, a) => ResubscribeForAddedContacts();
PortGather = new CommunicationGather(Communication, Delimiters) {IncludeDelimiter = true}; PortGather = new CommunicationGather(Communication, Delimiters) {IncludeDelimiter = true};
PortGather.LineReceived += Port_LineReceived; PortGather.LineReceived += Port_LineReceived;
@ -1017,10 +1019,11 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom
// Currently the feedback exclusions don't work when using the API in JSON response mode // Currently the feedback exclusions don't work when using the API in JSON response mode
// But leave these here in case the API gets updated in the future // But leave these here in case the API gets updated in the future
// These may work as of 5.9.4 // These may work as of 5.9.4
if (_props.DisablePhonebookAutoDownload)
{ // In 5.9.4 we're getting sent an AddedContact message for every contact in the phonebook on connect, which is redunant and way too much data
SendText("zFeedback Register Op: ex Path: /Event/Phonebook/AddedContact"); // We want to exclude these messages right away until after we've retrieved the entire phonebook and then we can re-enable them
} SendText("zFeedback Register Op: ex Path: /Event/Phonebook/AddedContact");
SendText("zFeedback Register Op: ex Path: /Event/InfoResult/Info/callin_country_list"); SendText("zFeedback Register Op: ex Path: /Event/InfoResult/Info/callin_country_list");
SendText("zFeedback Register Op: ex Path: /Event/InfoResult/Info/callout_country_list"); SendText("zFeedback Register Op: ex Path: /Event/InfoResult/Info/callout_country_list");
SendText("zFeedback Register Op: ex Path: /Event/InfoResult/Info/toll_free_callinLlist"); SendText("zFeedback Register Op: ex Path: /Event/InfoResult/Info/toll_free_callinLlist");
@ -1028,6 +1031,14 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.ZoomRoom
SendText("zStatus SystemUnit"); SendText("zStatus SystemUnit");
} }
/// <summary>
/// Removes the feedback exclusion for added contacts
/// </summary>
private void ResubscribeForAddedContacts()
{
SendText("zFeedback Register Op: in Path: /Event/Phonebook/AddedContact");
}
/// <summary> /// <summary>
/// Processes non-JSON responses as their are received /// Processes non-JSON responses as their are received
/// </summary> /// </summary>