pepperdash/PepperDashCore
1
0
Fork 0
mirror of https://github.com/PepperDash/PepperDashCore.git synced 2026-02-13 03:34:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reworks dequeueing and CCriticalSection usage to ensure proper threading behavoir.

Browse Source
This commit is contained in:
Neil Dorin
2019-04-24 11:16:57 -06:00
parent 54324d7e43
commit 47b0399e3a
1 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
Pepperdash Core/Pepperdash Core/Comm/GenericUdpServer.cs
View File

@@ -199,35 +199,38 @@ namespace PepperDash.Core
Debug.Console(2, this, "textHandler is null");
}
server.ReceiveDataAsync(Receive);
CrestronInvoke.BeginInvoke(DequeueEvent);
var gotLock = DequeueLock.TryEnter();
if (gotLock)
CrestronInvoke.BeginInvoke((o) => DequeueEvent());
}
void DequeueEvent(object notUsed)
/// <summary>
/// This method gets spooled up in its own thread an protected by a CCriticalSection to prevent multiple threads from running concurrently.
/// It will dequeue items as they are enqueued automatically.
/// </summary>
void DequeueEvent()
{
try
{
// Add CCritical Section
DequeueLock.TryEnter();
while (!MessageQueue.IsEmpty)
{
// Pull from Queue and fire an event.
var Message = MessageQueue.TryToDequeue();
var dataRecivedExtra = DataRecievedExtra;
if (dataRecivedExtra != null)
{
dataRecivedExtra(this, Message);
}
}
}
while (true)
{
// Pull from Queue and fire an event. Block indefinitely until an item can be removed, similar to a Gather.
var message = MessageQueue.Dequeue();
var dataRecivedExtra = DataRecievedExtra;
if (dataRecivedExtra != null)
{
dataRecivedExtra(this, message);
}
}
}
catch (Exception e)
{
Debug.Console(0, "GenericUdpServer DequeueEvent error: {0}\r", e);
}
finally
{
// Make sure to leave the CCritical section in case an exception above stops this thread, or we won't be able to restart it.
DequeueLock.Leave();
}
}
@@ -255,8 +258,6 @@ namespace PepperDash.Core
Server.SendData(bytes, bytes.Length);
}
}
public class GenericUdpReceiveTextExtraArgs : EventArgs