diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 17fcebf..9e09430 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -44,7 +44,7 @@ jobs: shell: powershell run: | $version = ./.github/scripts/GenerateVersionNumber.ps1 - Write-Output "::set-env name=VERSION::$version" + echo "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append # Use the version number to set the version of the assemblies - name: Update AssemblyInfo.cs shell: powershell @@ -123,7 +123,7 @@ jobs: Get-ChildItem "./Version" $version = Get-Content -Path ./Version/version.txt Write-Host "Version: $version" - Write-Output "::set-env name=VERSION::$version" + echo "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append Remove-Item -Path ./Version/version.txt Remove-Item -Path ./Version - name: Download Build output @@ -178,7 +178,7 @@ jobs: Get-ChildItem "./Version" $version = Get-Content -Path ./Version/version.txt Write-Host "Version: $version" - Write-Output "::set-env name=VERSION::$version" + echo "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append Remove-Item -Path ./Version/version.txt Remove-Item -Path ./Version # Checkout/Create the branch @@ -255,7 +255,7 @@ jobs: Get-ChildItem "./Version" $version = Get-Content -Path ./Version/version.txt Write-Host "Version: $version" - Write-Output "::set-env name=VERSION::$version" + echo "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append Remove-Item -Path ./Version/version.txt Remove-Item -Path ./Version # Checkout/Create the branch diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index b41e08c..db83b18 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -37,7 +37,7 @@ jobs: shell: powershell env: TAG_NAME: ${{ github.event.release.tag_name }} - run: Write-Output "::set-env name=VERSION::$($Env:TAG_NAME)" + run: echo "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append # Use the version number to set the version of the assemblies - name: Update AssemblyInfo.cs shell: powershell @@ -98,7 +98,7 @@ jobs: Get-ChildItem "./Version" $version = Get-Content -Path ./Version/version.txt Write-Host "Version: $version" - Write-Output "::set-env name=VERSION::$version" + echo "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append Remove-Item -Path ./Version/version.txt Remove-Item -Path ./Version - name: Download Build output @@ -152,7 +152,7 @@ jobs: Get-ChildItem "./Version" $version = Get-Content -Path ./Version/version.txt Write-Host "Version: $version" - Write-Output "::set-env name=VERSION::$version" + echo "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append Remove-Item -Path ./Version/version.txt Remove-Item -Path ./Version # Checkout/Create the branch @@ -225,7 +225,7 @@ jobs: Get-ChildItem "./Version" $version = Get-Content -Path ./Version/version.txt Write-Host "Version: $version" - Write-Output "::set-env name=VERSION::$version" + echo "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append Remove-Item -Path ./Version/version.txt Remove-Item -Path ./Version # Checkout/Create the branch diff --git a/Pepperdash Core/Pepperdash Core/Comm/CommunicationStreamDebugging.cs b/Pepperdash Core/Pepperdash Core/Comm/CommunicationStreamDebugging.cs index f3b5613..b5b1c15 100644 --- a/Pepperdash Core/Pepperdash Core/Comm/CommunicationStreamDebugging.cs +++ b/Pepperdash Core/Pepperdash Core/Comm/CommunicationStreamDebugging.cs @@ -79,10 +79,7 @@ namespace PepperDash.Core _DebugTimeoutInMs = minutes * 60000; - if (DebugExpiryPeriod != null) - { - DisableDebugging(); - } + StopDebugTimer(); DebugExpiryPeriod = new CTimer((o) => DisableDebugging(), _DebugTimeoutInMs); @@ -101,14 +98,24 @@ namespace PepperDash.Core /// private void DisableDebugging() { - DebugExpiryPeriod.Stop(); - DebugExpiryPeriod.Dispose(); - DebugExpiryPeriod = null; + StopDebugTimer(); + Debug.SetDeviceDebugSettings(ParentDeviceKey, eStreamDebuggingSetting.Off); + } + + private void StopDebugTimer() + { RxStreamDebuggingIsEnabled = false; TxStreamDebuggingIsEnabled = false; - Debug.SetDeviceDebugSettings(ParentDeviceKey, eStreamDebuggingSetting.Off); + if (DebugExpiryPeriod == null) + { + return; + } + + DebugExpiryPeriod.Stop(); + DebugExpiryPeriod.Dispose(); + DebugExpiryPeriod = null; } } @@ -123,4 +130,4 @@ namespace PepperDash.Core Tx = 2, Both = Rx | Tx } -} \ No newline at end of file +} diff --git a/Pepperdash Core/Pepperdash Core/Comm/GenericTcpIpClient.cs b/Pepperdash Core/Pepperdash Core/Comm/GenericTcpIpClient.cs index 7303d01..f151b57 100644 --- a/Pepperdash Core/Pepperdash Core/Comm/GenericTcpIpClient.cs +++ b/Pepperdash Core/Pepperdash Core/Comm/GenericTcpIpClient.cs @@ -313,7 +313,7 @@ namespace PepperDash.Core void ConnectToServerCallback(TCPClient c) { Debug.Console(1, this, "Server connection result: {0}", c.ClientStatus); - if (c.ClientStatus != SocketStatus.SOCKET_STATUS_CONNECTED) + if (c.ClientStatus != SocketStatus.SOCKET_STATUS_CONNECTED && AutoReconnect) WaitAndTryReconnect(); } @@ -326,7 +326,7 @@ namespace PepperDash.Core if (Client != null) { - Debug.Console(1, "Attempting reconnect, status={0}", Client.ClientStatus); + Debug.Console(1, this, "Attempting reconnect, status={0}", Client.ClientStatus); if (!DisconnectCalledByUser) RetryTimer = new CTimer(o => { Client.ConnectToServerAsync(ConnectToServerCallback); }, AutoReconnectIntervalMs); diff --git a/Pepperdash Core/Pepperdash Core/Logging/DebugMemory.cs b/Pepperdash Core/Pepperdash Core/Logging/DebugMemory.cs index 1b0fea1..5162853 100644 --- a/Pepperdash Core/Pepperdash Core/Logging/DebugMemory.cs +++ b/Pepperdash Core/Pepperdash Core/Logging/DebugMemory.cs @@ -68,11 +68,9 @@ namespace PepperDash.Core.DebugThings /// public void SetDebugSettingsForKey(string deviceKey, object settings) { - var existingSettings = DeviceDebugSettings[deviceKey]; - - if (existingSettings != null) + if(DeviceDebugSettings.ContainsKey(deviceKey)) { - existingSettings = settings; + DeviceDebugSettings[deviceKey] = settings; } else DeviceDebugSettings.Add(deviceKey, settings); diff --git a/Pepperdash Core/Pepperdash Core/XSigUtility/Tokens/XSigSerialToken.cs b/Pepperdash Core/Pepperdash Core/XSigUtility/Tokens/XSigSerialToken.cs index 845b297..cc61b1f 100644 --- a/Pepperdash Core/Pepperdash Core/XSigUtility/Tokens/XSigSerialToken.cs +++ b/Pepperdash Core/Pepperdash Core/XSigUtility/Tokens/XSigSerialToken.cs @@ -29,7 +29,8 @@ namespace PepperDash.Core.Intersystem.Tokens public override byte[] GetBytes() { - var serialBytes = Encoding.GetEncoding(28591).GetBytes(Value); + var serialBytes = String.IsNullOrEmpty(Value) ? new byte[0] : Encoding.GetEncoding(28591).GetBytes(Value); + var xsig = new byte[serialBytes.Length + 3]; xsig[0] = (byte)(0xC8 | (Index >> 7)); xsig[1] = (byte)((Index - 1) & 0x7F);