From 93f0f4cbfed780b2aecc9a4d5921ba451c35a8ef Mon Sep 17 00:00:00 2001 From: jdevito Date: Mon, 5 May 2025 13:15:44 -0500 Subject: [PATCH 1/3] feat: add method to delete the last character in the password field --- .../PasswordManagement/PasswordClient.cs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Pepperdash Core/Pepperdash Core/PasswordManagement/PasswordClient.cs b/Pepperdash Core/Pepperdash Core/PasswordManagement/PasswordClient.cs index e286733..cc1f342 100644 --- a/Pepperdash Core/Pepperdash Core/PasswordManagement/PasswordClient.cs +++ b/Pepperdash Core/Pepperdash Core/PasswordManagement/PasswordClient.cs @@ -121,6 +121,16 @@ namespace PepperDash.Core.PasswordManagement OnBoolChange(false, (ushort)PasswordToValidate.Length, PasswordManagementConstants.PasswordLedFeedbackChange); } + /// + /// Deletes the last character in the currently entered password field + /// + public void DeletePasswordCharacter() + { + PasswordToValidate = PasswordToValidate.Substring(0, PasswordToValidate.Length - 1); + OnBoolChange(false, (ushort)PasswordToValidate.Length, PasswordManagementConstants.PasswordLedFeedbackChange); + // Verify if OnStringChange is needed to update the S+ wrapper with the entered PasswordToValidate + } + /// /// Protected boolean change event handler /// From 69ea8589cca5720a96f1e9a243830e34c0212a09 Mon Sep 17 00:00:00 2001 From: Jonathan Arndt Date: Mon, 5 May 2025 13:19:48 -0700 Subject: [PATCH 2/3] fix: update DeletePasswordCharacter method to use length before deletion for proper LED feedback. --- .../Pepperdash Core/PasswordManagement/PasswordClient.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Pepperdash Core/Pepperdash Core/PasswordManagement/PasswordClient.cs b/Pepperdash Core/Pepperdash Core/PasswordManagement/PasswordClient.cs index cc1f342..f965dfa 100644 --- a/Pepperdash Core/Pepperdash Core/PasswordManagement/PasswordClient.cs +++ b/Pepperdash Core/Pepperdash Core/PasswordManagement/PasswordClient.cs @@ -126,8 +126,9 @@ namespace PepperDash.Core.PasswordManagement /// public void DeletePasswordCharacter() { + ushort PasswordLengthBeforeDelete = (ushort)PasswordToValidate.Length; PasswordToValidate = PasswordToValidate.Substring(0, PasswordToValidate.Length - 1); - OnBoolChange(false, (ushort)PasswordToValidate.Length, PasswordManagementConstants.PasswordLedFeedbackChange); + OnBoolChange(false, (ushort)PasswordLengthBeforeDelete, PasswordManagementConstants.PasswordLedFeedbackChange); // Verify if OnStringChange is needed to update the S+ wrapper with the entered PasswordToValidate } From eb4c2cd3867d5fc8f3b80e3b9773fcf8eafd5af6 Mon Sep 17 00:00:00 2001 From: Jonathan Arndt Date: Mon, 5 May 2025 13:29:11 -0700 Subject: [PATCH 3/3] chore: remove add-issues-to-project workflow file. --- .github/workflows/add-issues-to-project.yml | 37 --------------------- 1 file changed, 37 deletions(-) delete mode 100644 .github/workflows/add-issues-to-project.yml diff --git a/.github/workflows/add-issues-to-project.yml b/.github/workflows/add-issues-to-project.yml deleted file mode 100644 index 8811c0c..0000000 --- a/.github/workflows/add-issues-to-project.yml +++ /dev/null @@ -1,37 +0,0 @@ -name: Add bugs to bugs project - -on: - issues: - types: - - opened - - labeled - -jobs: - check-secret: - runs-on: ubuntu-latest - outputs: - my-key: ${{ steps.my-key.outputs.defined }} - steps: - - id: my-key - if: "${{ env.MY_KEY != '' }}" - run: echo "::set-output name=defined::true" - env: - MY_KEY: ${{ secrets.PROJECT_URL }} - throw-error: - name: Check - runs-on: ubuntu-latest - needs: [check-secret] - if: needs.check-secret.outputs.my-key != 'true' - steps: - - run: echo "The Project URL Repo Secret is empty" - add-to-project: - name: Add issue to project - runs-on: ubuntu-latest - needs: [check-secret] - if: needs.check-secret.outputs.my-key == 'true' - steps: - - uses: actions/add-to-project@main - with: - project-url: ${{ secrets.PROJECT_URL }} - github-token: ${{ secrets.GH_PROJECTS_PASSWORD }} -