Added a null check to determining SIP information

Resolves #290

.github/scripts/GenerateVersionNumber.ps1

@@ -1,8 +1,5 @@
 $latestVersions = $(git tag --merged origin/main)
 $latestVersion = [version]"0.0.0"
-Write-Host "GITHUB_REF: $($Env:GITHUB_REF)"
-Write-Host "GITHUB_HEAD_REF: $($Env:GITHUB_HEAD_REF)"
-Write-Host "GITHUB_BASE_REF: $($Env:GITHUB_BASE_REF)"
 Foreach ($version in $latestVersions) {
   Write-Host $version
   try {
@@ -20,13 +17,7 @@ Foreach ($version in $latestVersions) {
 $newVersion = [version]$latestVersion
 $phase = ""
 $newVersionString = ""
-
 switch -regex ($Env:GITHUB_REF) {
-  '^refs\/pull\/*.' {
-    $splitRef = $Env:GITHUB_REF -split "/"
-    $phase = "pr$($splitRef[2])"
-    $newVersionString = "{0}.{1}.{2}-{3}-{4}" -f $newVersion.Major, $newVersion.Minor, ($newVersion.Build + 1), $phase, $Env:GITHUB_RUN_NUMBER
-  }
   '^refs\/heads\/main*.' {
     $newVersionString = "{0}.{1}.{2}" -f $newVersion.Major, $newVersion.Minor, $newVersion.Build
   }
@@ -52,7 +43,6 @@ switch -regex ($Env:GITHUB_REF) {
     $phase = 'hotfix'
     $newVersionString = "{0}.{1}.{2}-{3}-{4}" -f $newVersion.Major, $newVersion.Minor, ($newVersion.Build + 1), $phase, $Env:GITHUB_RUN_NUMBER
   }
-  
 }
 
 

.github/workflows/docker.yml

@@ -8,9 +8,6 @@ on:
       - bugfix/*
       - release/*
       - development
-  pull_request:
-    branches:
-      - development
 
 env:
   # solution path doesn't need slashes unless there it is multiple folders deep
@@ -32,7 +29,14 @@ jobs:
         uses: actions/checkout@v2
         with:
           fetch-depth: 0
-          submodules: true
+      # And any submodules
+      - name: Checkout submodules
+        shell: bash
+        run: |
+          git config --global url."https://github.com/".insteadOf "git@github.com:"
+          auth_header="$(git config --local --get http.https://github.com/.extraheader)"
+          git submodule sync --recursive
+          git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
         # Fetch all tags
       - name: Fetch tags
         run: git fetch --tags

PepperDashEssentials/Example Configuration/SIMPLBridging/SIMPLBridgeExample_configurationFile.json

@@ -175,10 +175,6 @@
             {
               "deviceKey": "gls-odt-1",
               "joinStart": 2751
-            },
-            {
-				"deviceKey": "gls-part-1",
-				"joinStart": 2781
             }
           ]
         }
@@ -431,19 +427,6 @@
             "method": "cresnet"
           }
         }
-      },
-      {
-        "key": "gls-part-1",
-        "uid": 19,
-        "name": "GLS-PART-CN 1",
-        "type": "glspartcn",
-        "group": "partition",
-        "properties": {
-          "control": {
-            "cresnetId": "90",
-            "method": "cresnet"
-          }
-        }
       }
     ],
     "rooms": [],

essentials-framework/Essentials Core/PepperDashEssentialsBase/Bridges/JoinMaps/GlsPartitionSensorJoinMap.cs

@@ -1,130 +0,0 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using Crestron.SimplSharp;
-using PepperDash.Essentials.Core;
-
-namespace PepperDash_Essentials_Core.Bridges.JoinMaps
-{
-	public class GlsPartitionSensorJoinMap : JoinMapBaseAdvanced
-	{
-		[JoinName("IsOnline")]
-		public JoinDataComplete IsOnline = new JoinDataComplete(
-			new JoinData()
-			{
-				JoinNumber = 1,
-				JoinSpan = 1
-			},
-			new JoinMetadata()
-			{
-				Description = "Sensor Is Online",
-				JoinCapabilities = eJoinCapabilities.ToSIMPL,
-				JoinType = eJoinType.Digital
-			});
-
-		[JoinName("Name")]
-		public JoinDataComplete Name = new JoinDataComplete(
-			new JoinData()
-			{
-				JoinNumber = 1,
-				JoinSpan = 1
-			},
-			new JoinMetadata()
-			{
-				Description = "Sensor Name",
-				JoinCapabilities = eJoinCapabilities.ToSIMPL,
-				JoinType = eJoinType.Serial
-			});
-
-		[JoinName("Enable")]
-		public JoinDataComplete Enable = new JoinDataComplete(
-			new JoinData()
-			{
-				JoinNumber = 2,
-				JoinSpan = 1
-			},
-			new JoinMetadata()
-			{
-				Description = "Sensor Enable",
-				JoinCapabilities = eJoinCapabilities.ToFromSIMPL,
-				JoinType = eJoinType.Digital
-			});
-
-		[JoinName("PartitionSensed")]
-		public JoinDataComplete PartitionSensed = new JoinDataComplete(
-			new JoinData()
-			{
-				JoinNumber = 3,
-				JoinSpan = 1
-			},
-			new JoinMetadata()
-			{
-				Description = "Sensor Partition Sensed",
-				JoinCapabilities = eJoinCapabilities.ToSIMPL,
-				JoinType = eJoinType.Digital
-			});
-
-		[JoinName("PartitionNotSensed")]
-		public JoinDataComplete PartitionNotSensed = new JoinDataComplete(
-			new JoinData()
-			{
-				JoinNumber = 4,
-				JoinSpan = 1
-			},
-			new JoinMetadata()
-			{
-				Description = "Sensor Partition Not Sensed",
-				JoinCapabilities = eJoinCapabilities.ToSIMPL,
-				JoinType = eJoinType.Digital
-			});
-
-		[JoinName("IncreaseSensitivity")]
-		public JoinDataComplete IncreaseSensitivity = new JoinDataComplete(
-			new JoinData()
-			{
-				JoinNumber = 6,
-				JoinSpan = 1
-			},
-			new JoinMetadata()
-			{
-				Description = "Sensor Increase Sensitivity",
-				JoinCapabilities = eJoinCapabilities.FromSIMPL,
-				JoinType = eJoinType.Digital
-			});
-
-		[JoinName("DecreaseSensitivity")]
-		public JoinDataComplete DecreaseSensitivity = new JoinDataComplete(
-			new JoinData()
-			{
-				JoinNumber = 7,
-				JoinSpan = 1
-			},
-			new JoinMetadata()
-			{
-				Description = "Sensor Decrease Sensitivity",
-				JoinCapabilities = eJoinCapabilities.FromSIMPL,
-				JoinType = eJoinType.Digital
-			});
-
-		[JoinName("Sensitivity")]
-		public JoinDataComplete Sensitivity = new JoinDataComplete(
-			new JoinData()
-			{
-				JoinNumber = 2,
-				JoinSpan = 1
-			},
-			new JoinMetadata()
-			{
-				Description = "Sensor Sensitivity",
-				JoinCapabilities = eJoinCapabilities.ToFromSIMPL,
-				JoinType = eJoinType.Analog
-			});
-
-		public GlsPartitionSensorJoinMap(uint joinStart)
-			: base(joinStart, typeof (GlsPartitionSensorJoinMap))
-		{
-
-		}
-	}
-}

essentials-framework/Essentials Core/PepperDashEssentialsBase/JoinMaps/JoinMapBase.cs

@@ -1,488 +1,488 @@
-using System;
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Runtime.InteropServices;
-using Crestron.SimplSharp.Reflection;
-
-using PepperDash.Core;
-using PepperDash.Essentials.Core.Config;
-
-using Newtonsoft.Json;
-
-namespace PepperDash.Essentials.Core
-{
-    public static class JoinMapHelper
-    {
-        /// <summary>
-        /// Attempts to get the serialized join map from config
-        /// </summary>
-        /// <param name="joinMapKey"></param>
-        /// <returns></returns>
-        public static string GetSerializedJoinMapForDevice(string joinMapKey)
-        {
-            if (string.IsNullOrEmpty(joinMapKey))
-                return null;
-
-            var joinMap = ConfigReader.ConfigObject.JoinMaps[joinMapKey];
-
-            return joinMap;
-        }
-
-        /// <summary>
-        /// Attempts to get the serialized join map from config
-        /// </summary>
-        /// <param name="joinMapKey"></param>
-        /// <returns></returns>
-        public static string GetJoinMapForDevice(string joinMapKey)
-        {
-            return GetSerializedJoinMapForDevice(joinMapKey);
-        }
-
-        /// <summary>
-        /// Attempts to find a custom join map by key and returns it deserialized if found
-        /// </summary>
-        /// <param name="joinMapKey"></param>
-        /// <returns></returns>
-        public static Dictionary<string, JoinData> TryGetJoinMapAdvancedForDevice(string joinMapKey)
-        {
-            if (string.IsNullOrEmpty(joinMapKey))
-                return null;
-
-            var joinMapSerialzed = ConfigReader.ConfigObject.JoinMaps[joinMapKey];
-
-            if (joinMapSerialzed == null) return null;
-
-            var joinMapData = JsonConvert.DeserializeObject<Dictionary<string, JoinData>>(joinMapSerialzed);
-
-            return joinMapData;
-        }
-
-    }
-
-    /// <summary>
-    /// Base class for join maps
-    /// </summary>
-    [Obsolete("This is being deprecated in favor of JoinMapBaseAdvanced")]
-    public abstract class JoinMapBase
-    {
-        /// <summary>
-        /// Modifies all the join numbers by adding the offset.  This should never be called twice
-        /// </summary>
-        /// <param name="joinStart"></param>
-        public abstract void OffsetJoinNumbers(uint joinStart);
-
-        /// <summary>
-        /// The collection of joins and associated metadata
-        /// </summary>
-        public Dictionary<string, JoinMetadata> Joins = new Dictionary<string, JoinMetadata>();
-
-        /// <summary>
-        /// Prints the join information to console
-        /// </summary>
-        public void PrintJoinMapInfo()
-        {
-            Debug.Console(0, "{0}:\n", GetType().Name);
-
-            // Get the joins of each type and print them
-            Debug.Console(0, "Digitals:");
-            var digitals = Joins.Where(j => (j.Value.JoinType & eJoinType.Digital) == eJoinType.Digital).ToDictionary(j => j.Key, j => j.Value);
-            Debug.Console(2, "Found {0} Digital Joins", digitals.Count); 
-            PrintJoinList(GetSortedJoins(digitals));
-
-            Debug.Console(0, "Analogs:");
-            var analogs = Joins.Where(j => (j.Value.JoinType & eJoinType.Analog) == eJoinType.Analog).ToDictionary(j => j.Key, j => j.Value);
-            Debug.Console(2, "Found {0} Analog Joins", analogs.Count); 
-            PrintJoinList(GetSortedJoins(analogs));
-
-            Debug.Console(0, "Serials:");
-            var serials = Joins.Where(j => (j.Value.JoinType & eJoinType.Serial) == eJoinType.Serial).ToDictionary(j => j.Key, j => j.Value);
-            Debug.Console(2, "Found {0} Serial Joins", serials.Count);
-            PrintJoinList(GetSortedJoins(serials));
-
-        }
-
-        /// <summary>
-        /// Returns  a sorted list by JoinNumber
-        /// </summary>
-        /// <param name="joins"></param>
-        /// <returns></returns>
-        List<KeyValuePair<string, JoinMetadata>> GetSortedJoins(Dictionary<string, JoinMetadata> joins)
-        {
-            var sortedJoins = joins.ToList();
-
-            sortedJoins.Sort((pair1, pair2) => pair1.Value.JoinNumber.CompareTo(pair2.Value.JoinNumber));
-
-            return sortedJoins;
-        }
-
-        void PrintJoinList(List<KeyValuePair<string, JoinMetadata>> joins)
-        {
-            foreach (var join in joins)
-            {
-                Debug.Console(0,
-                    @"Join Number: {0} | Label: '{1}' | JoinSpan: '{2}' | Type: '{3}' | Capabilities: '{4}'",
-                        join.Value.JoinNumber,
-                        join.Value.Label,
-                        join.Value.JoinSpan,
-                        join.Value.JoinType.ToString(),
-                        join.Value.JoinCapabilities.ToString());
-            }
-        }
-
-        /// <summary>
-        /// Returns the join number for the join with the specified key
-        /// </summary>
-        /// <param name="key"></param>
-        /// <returns></returns>
-        public uint GetJoinForKey(string key)
-        {
-            return Joins.ContainsKey(key) ? Joins[key].JoinNumber : 0;
-        }
-
-        /// <summary>
-        /// Returns the join span for the join with the specified key
-        /// </summary>
-        /// <param name="key"></param>
-        /// <returns></returns>
-        public uint GetJoinSpanForKey(string key)
-        {
-            return Joins.ContainsKey(key) ? Joins[key].JoinSpan : 0;
-        }
-    }
-
-    /// <summary>
-    /// Base class for join maps
-    /// </summary>
-    public abstract class JoinMapBaseAdvanced
-    {
-        protected uint JoinOffset;
-
-        /// <summary>
-        /// The collection of joins and associated metadata
-        /// </summary>
-        public Dictionary<string, JoinDataComplete> Joins { get; private set; }
-
-        protected JoinMapBaseAdvanced(uint joinStart)
-        {
-            Joins = new Dictionary<string, JoinDataComplete>();
-
-            JoinOffset = joinStart - 1;
-        }
-
-        protected JoinMapBaseAdvanced(uint joinStart, Type type):this(joinStart)
-        {
-            AddJoins(type);
-        }
-
-        protected void AddJoins(Type type)
-        {
-            // Add all the JoinDataComplete properties to the Joins Dictionary and pass in the offset 
-            //Joins = this.GetType()
-            //    .GetCType()
-            //    .GetFields(BindingFlags.Public | BindingFlags.Instance)
-            //    .Where(field => field.IsDefined(typeof(JoinNameAttribute), true))
-            //    .Select(field => (JoinDataComplete)field.GetValue(this))
-            //    .ToDictionary(join => join.GetNameAttribute(), join =>
-            //        {
-            //            join.SetJoinOffset(_joinOffset);
-            //            return join;
-            //        });
-
-            //type = this.GetType(); <- this wasn't working because 'this' was always the base class, never the derived class
-            var fields =
-                type.GetCType()
-                    .GetFields(BindingFlags.Public | BindingFlags.Instance)
-                    .Where(f => f.IsDefined(typeof (JoinNameAttribute), true));
-
-            foreach (var field in fields)
-            {
-                var childClass = Convert.ChangeType(this, type, null);
-
-                var value = field.GetValue(childClass) as JoinDataComplete; //this here is JoinMapBaseAdvanced, not the child class. JoinMapBaseAdvanced has no fields.
-
-                if (value == null)
-                {
-                    Debug.Console(0, "Unable to caset base class to {0}", type.Name);
-                    continue;
-                }
-
-                value.SetJoinOffset(JoinOffset);
-
-                var joinName = value.GetNameAttribute(field);
-
-                if (String.IsNullOrEmpty(joinName)) continue;
-
-                Joins.Add(joinName, value);
-            }
-
-
-            PrintJoinMapInfo();
-        }
-
-        /// <summary>
-        /// Prints the join information to console
-        /// </summary>
-        public void PrintJoinMapInfo()
-        {
-            Debug.Console(0, "{0}:\n", GetType().Name);
-
-            // Get the joins of each type and print them
-            Debug.Console(0, "Digitals:");
-            var digitals = Joins.Where(j => (j.Value.Metadata.JoinType & eJoinType.Digital) == eJoinType.Digital).ToDictionary(j => j.Key, j => j.Value);
-            Debug.Console(2, "Found {0} Digital Joins", digitals.Count);
-            PrintJoinList(GetSortedJoins(digitals));
-
-            Debug.Console(0, "Analogs:");
-            var analogs = Joins.Where(j => (j.Value.Metadata.JoinType & eJoinType.Analog) == eJoinType.Analog).ToDictionary(j => j.Key, j => j.Value);
-            Debug.Console(2, "Found {0} Analog Joins", analogs.Count);
-            PrintJoinList(GetSortedJoins(analogs));
-            
-            Debug.Console(0, "Serials:");
-            var serials = Joins.Where(j => (j.Value.Metadata.JoinType & eJoinType.Serial) == eJoinType.Serial).ToDictionary(j => j.Key, j => j.Value);
-            Debug.Console(2, "Found {0} Serial Joins", serials.Count);
-            PrintJoinList(GetSortedJoins(serials));
-
-        }
-
-        /// <summary>
-        /// Returns  a sorted list by JoinNumber
-        /// </summary>
-        /// <param name="joins"></param>
-        /// <returns></returns>
-        List<KeyValuePair<string, JoinDataComplete>> GetSortedJoins(Dictionary<string, JoinDataComplete> joins)
-        {
-            var sortedJoins = joins.ToList();
-
-            sortedJoins.Sort((pair1, pair2) => pair1.Value.JoinNumber.CompareTo(pair2.Value.JoinNumber));
-
-            return sortedJoins;
-        }
-
-        void PrintJoinList(List<KeyValuePair<string, JoinDataComplete>> joins)
-        {
-            foreach (var join in joins)
-            {
-                Debug.Console(0,
-                    @"Join Number: {0} | JoinSpan: '{1}' | Label: '{2}' | Type: '{3}' | Capabilities: '{4}'",
-                        join.Value.JoinNumber,
-                        join.Value.JoinSpan,
-                        join.Value.Metadata.Label,
-                        join.Value.Metadata.JoinType.ToString(),
-                        join.Value.Metadata.JoinCapabilities.ToString());
-            }
-        }
-
-        /// <summary>
-        /// Attempts to find the matching key for the custom join and if found overwrites the default JoinData with the custom
-        /// </summary>
-        /// <param name="joinData"></param>
-        public void SetCustomJoinData(Dictionary<string, JoinData> joinData)
-        {
-            foreach (var customJoinData in joinData)
-            {
-                var join = Joins[customJoinData.Key];
-
-                if (join != null)
-                {
-                    join.SetCustomJoinData(customJoinData.Value);
-                }
-                else
-                {
-                    Debug.Console(2, "No mathcing key found in join map for: '{0}'", customJoinData.Key);
-                }
-            }
-
-            PrintJoinMapInfo();
-        }
-
-        ///// <summary>
-        ///// Returns the join number for the join with the specified key
-        ///// </summary>
-        ///// <param name="key"></param>
-        ///// <returns></returns>
-        //public uint GetJoinForKey(string key)
-        //{
-        //    return Joins.ContainsKey(key) ? Joins[key].JoinNumber : 0;
-        //}
-
-
-        ///// <summary>
-        ///// Returns the join span for the join with the specified key
-        ///// </summary>
-        ///// <param name="key"></param>
-        ///// <returns></returns>
-        //public uint GetJoinSpanForKey(string key)
-        //{
-        //    return Joins.ContainsKey(key) ? Joins[key].JoinSpan : 0;
-        //}
-    }
-
-    /// <summary>
-    /// Read = Provides feedback to SIMPL
-    /// Write = Responds to sig values from SIMPL
-    /// </summary>
-    [Flags]
-    public enum eJoinCapabilities
-    {
-        None = 0,
-        ToSIMPL = 1,
-        FromSIMPL = 2,
-        ToFromSIMPL = ToSIMPL | FromSIMPL
-    }
-
-    [Flags]
-    public enum eJoinType
-    {
-        None = 0,
-        Digital = 1,
-        Analog = 2,
-        Serial = 4,
-        DigitalAnalog = Digital | Analog,
-        DigitalSerial = Digital | Serial,
-        AnalogSerial = Analog | Serial,
-        DigitalAnalogSerial = Digital | Analog | Serial
-    }
-
-    /// <summary>
-    /// Metadata describing the join
-    /// </summary>
+using Crestron.SimplSharp.Reflection;
+
+using PepperDash.Core;
+using PepperDash.Essentials.Core.Config;
+
+using Newtonsoft.Json;
+
+namespace PepperDash.Essentials.Core
+{
+    public static class JoinMapHelper
+    {
+        /// <summary>
+        /// Attempts to get the serialized join map from config
+        /// </summary>
+        /// <param name="joinMapKey"></param>
+        /// <returns></returns>
+        public static string GetSerializedJoinMapForDevice(string joinMapKey)
+        {
+            if (string.IsNullOrEmpty(joinMapKey))
+                return null;
+
+            var joinMap = ConfigReader.ConfigObject.JoinMaps[joinMapKey];
+
+            return joinMap;
+        }
+
+        /// <summary>
+        /// Attempts to get the serialized join map from config
+        /// </summary>
+        /// <param name="joinMapKey"></param>
+        /// <returns></returns>
+        public static string GetJoinMapForDevice(string joinMapKey)
+        {
+            return GetSerializedJoinMapForDevice(joinMapKey);
+        }
+
+        /// <summary>
+        /// Attempts to find a custom join map by key and returns it deserialized if found
+        /// </summary>
+        /// <param name="joinMapKey"></param>
+        /// <returns></returns>
+        public static Dictionary<string, JoinData> TryGetJoinMapAdvancedForDevice(string joinMapKey)
+        {
+            if (string.IsNullOrEmpty(joinMapKey))
+                return null;
+
+            var joinMapSerialzed = ConfigReader.ConfigObject.JoinMaps[joinMapKey];
+
+            if (joinMapSerialzed == null) return null;
+
+            var joinMapData = JsonConvert.DeserializeObject<Dictionary<string, JoinData>>(joinMapSerialzed);
+
+            return joinMapData;
+        }
+
+    }
+
+    /// <summary>
+    /// Base class for join maps
+    /// </summary>
+    [Obsolete("This is being deprecated in favor of JoinMapBaseAdvanced")]
+    public abstract class JoinMapBase
+    {
+        /// <summary>
+        /// Modifies all the join numbers by adding the offset.  This should never be called twice
+        /// </summary>
+        /// <param name="joinStart"></param>
+        public abstract void OffsetJoinNumbers(uint joinStart);
+
+        /// <summary>
+        /// The collection of joins and associated metadata
+        /// </summary>
+        public Dictionary<string, JoinMetadata> Joins = new Dictionary<string, JoinMetadata>();
+
+        /// <summary>
+        /// Prints the join information to console
+        /// </summary>
+        public void PrintJoinMapInfo()
+        {
+            Debug.Console(0, "{0}:\n", GetType().Name);
+
+            // Get the joins of each type and print them
+            Debug.Console(0, "Digitals:");
+            var digitals = Joins.Where(j => (j.Value.JoinType & eJoinType.Digital) == eJoinType.Digital).ToDictionary(j => j.Key, j => j.Value);
+            Debug.Console(2, "Found {0} Digital Joins", digitals.Count); 
+            PrintJoinList(GetSortedJoins(digitals));
+
+            Debug.Console(0, "Analogs:");
+            var analogs = Joins.Where(j => (j.Value.JoinType & eJoinType.Analog) == eJoinType.Analog).ToDictionary(j => j.Key, j => j.Value);
+            Debug.Console(2, "Found {0} Analog Joins", analogs.Count); 
+            PrintJoinList(GetSortedJoins(analogs));
+
+            Debug.Console(0, "Serials:");
+            var serials = Joins.Where(j => (j.Value.JoinType & eJoinType.Serial) == eJoinType.Serial).ToDictionary(j => j.Key, j => j.Value);
+            Debug.Console(2, "Found {0} Serial Joins", serials.Count);
+            PrintJoinList(GetSortedJoins(serials));
+
+        }
+
+        /// <summary>
+        /// Returns  a sorted list by JoinNumber
+        /// </summary>
+        /// <param name="joins"></param>
+        /// <returns></returns>
+        List<KeyValuePair<string, JoinMetadata>> GetSortedJoins(Dictionary<string, JoinMetadata> joins)
+        {
+            var sortedJoins = joins.ToList();
+
+            sortedJoins.Sort((pair1, pair2) => pair1.Value.JoinNumber.CompareTo(pair2.Value.JoinNumber));
+
+            return sortedJoins;
+        }
+
+        void PrintJoinList(List<KeyValuePair<string, JoinMetadata>> joins)
+        {
+            foreach (var join in joins)
+            {
+                Debug.Console(0,
+                    @"Join Number: {0} | Label: '{1}' | JoinSpan: '{2}' | Type: '{3}' | Capabilities: '{4}'",
+                        join.Value.JoinNumber,
+                        join.Value.Label,
+                        join.Value.JoinSpan,
+                        join.Value.JoinType.ToString(),
+                        join.Value.JoinCapabilities.ToString());
+            }
+        }
+
+        /// <summary>
+        /// Returns the join number for the join with the specified key
+        /// </summary>
+        /// <param name="key"></param>
+        /// <returns></returns>
+        public uint GetJoinForKey(string key)
+        {
+            return Joins.ContainsKey(key) ? Joins[key].JoinNumber : 0;
+        }
+
+        /// <summary>
+        /// Returns the join span for the join with the specified key
+        /// </summary>
+        /// <param name="key"></param>
+        /// <returns></returns>
+        public uint GetJoinSpanForKey(string key)
+        {
+            return Joins.ContainsKey(key) ? Joins[key].JoinSpan : 0;
+        }
+    }
+
+    /// <summary>
+    /// Base class for join maps
+    /// </summary>
+    public abstract class JoinMapBaseAdvanced
+    {
+        protected uint JoinOffset;
+
+        /// <summary>
+        /// The collection of joins and associated metadata
+        /// </summary>
+        public Dictionary<string, JoinDataComplete> Joins { get; private set; }
+
+        protected JoinMapBaseAdvanced(uint joinStart)
+        {
+            Joins = new Dictionary<string, JoinDataComplete>();
+
+            JoinOffset = joinStart - 1;
+        }
+
+        protected JoinMapBaseAdvanced(uint joinStart, Type type):this(joinStart)
+        {
+            AddJoins(type);
+        }
+
+        protected void AddJoins(Type type)
+        {
+            // Add all the JoinDataComplete properties to the Joins Dictionary and pass in the offset 
+            //Joins = this.GetType()
+            //    .GetCType()
+            //    .GetFields(BindingFlags.Public | BindingFlags.Instance)
+            //    .Where(field => field.IsDefined(typeof(JoinNameAttribute), true))
+            //    .Select(field => (JoinDataComplete)field.GetValue(this))
+            //    .ToDictionary(join => join.GetNameAttribute(), join =>
+            //        {
+            //            join.SetJoinOffset(_joinOffset);
+            //            return join;
+            //        });
+
+            //type = this.GetType(); <- this wasn't working because 'this' was always the base class, never the derived class
+            var fields =
+                type.GetCType()
+                    .GetFields(BindingFlags.Public | BindingFlags.Instance)
+                    .Where(f => f.IsDefined(typeof (JoinNameAttribute), true));
+
+            foreach (var field in fields)
+            {
+                var childClass = Convert.ChangeType(this, type, null);
+
+                var value = field.GetValue(childClass) as JoinDataComplete; //this here is JoinMapBaseAdvanced, not the child class. JoinMapBaseAdvanced has no fields.
+
+                if (value == null)
+                {
+                    Debug.Console(0, "Unable to caset base class to {0}", type.Name);
+                    continue;
+                }
+
+                value.SetJoinOffset(JoinOffset);
+
+                var joinName = value.GetNameAttribute(field);
+
+                if (String.IsNullOrEmpty(joinName)) continue;
+
+                Joins.Add(joinName, value);
+            }
+
+
+            PrintJoinMapInfo();
+        }
+
+        /// <summary>
+        /// Prints the join information to console
+        /// </summary>
+        public void PrintJoinMapInfo()
+        {
+            Debug.Console(0, "{0}:\n", GetType().Name);
+
+            // Get the joins of each type and print them
+            Debug.Console(0, "Digitals:");
+            var digitals = Joins.Where(j => (j.Value.Metadata.JoinType & eJoinType.Digital) == eJoinType.Digital).ToDictionary(j => j.Key, j => j.Value);
+            Debug.Console(2, "Found {0} Digital Joins", digitals.Count);
+            PrintJoinList(GetSortedJoins(digitals));
+
+            Debug.Console(0, "Analogs:");
+            var analogs = Joins.Where(j => (j.Value.Metadata.JoinType & eJoinType.Analog) == eJoinType.Analog).ToDictionary(j => j.Key, j => j.Value);
+            Debug.Console(2, "Found {0} Analog Joins", analogs.Count);
+            PrintJoinList(GetSortedJoins(analogs));
+            
+            Debug.Console(0, "Serials:");
+            var serials = Joins.Where(j => (j.Value.Metadata.JoinType & eJoinType.Serial) == eJoinType.Serial).ToDictionary(j => j.Key, j => j.Value);
+            Debug.Console(2, "Found {0} Serial Joins", serials.Count);
+            PrintJoinList(GetSortedJoins(serials));
+
+        }
+
+        /// <summary>
+        /// Returns  a sorted list by JoinNumber
+        /// </summary>
+        /// <param name="joins"></param>
+        /// <returns></returns>
+        List<KeyValuePair<string, JoinDataComplete>> GetSortedJoins(Dictionary<string, JoinDataComplete> joins)
+        {
+            var sortedJoins = joins.ToList();
+
+            sortedJoins.Sort((pair1, pair2) => pair1.Value.JoinNumber.CompareTo(pair2.Value.JoinNumber));
+
+            return sortedJoins;
+        }
+
+        void PrintJoinList(List<KeyValuePair<string, JoinDataComplete>> joins)
+        {
+            foreach (var join in joins)
+            {
+                Debug.Console(0,
+                    @"Join Number: {0} | JoinSpan: '{1}' | Label: '{2}' | Type: '{3}' | Capabilities: '{4}'",
+                        join.Value.JoinNumber,
+                        join.Value.JoinSpan,
+                        join.Value.Metadata.Label,
+                        join.Value.Metadata.JoinType.ToString(),
+                        join.Value.Metadata.JoinCapabilities.ToString());
+            }
+        }
+
+        /// <summary>
+        /// Attempts to find the matching key for the custom join and if found overwrites the default JoinData with the custom
+        /// </summary>
+        /// <param name="joinData"></param>
+        public void SetCustomJoinData(Dictionary<string, JoinData> joinData)
+        {
+            foreach (var customJoinData in joinData)
+            {
+                var join = Joins[customJoinData.Key];
+
+                if (join != null)
+                {
+                    join.SetCustomJoinData(customJoinData.Value);
+                }
+                else
+                {
+                    Debug.Console(2, "No mathcing key found in join map for: '{0}'", customJoinData.Key);
+                }
+            }
+
+            PrintJoinMapInfo();
+        }
+
+        ///// <summary>
+        ///// Returns the join number for the join with the specified key
+        ///// </summary>
+        ///// <param name="key"></param>
+        ///// <returns></returns>
+        //public uint GetJoinForKey(string key)
+        //{
+        //    return Joins.ContainsKey(key) ? Joins[key].JoinNumber : 0;
+        //}
+
+
+        ///// <summary>
+        ///// Returns the join span for the join with the specified key
+        ///// </summary>
+        ///// <param name="key"></param>
+        ///// <returns></returns>
+        //public uint GetJoinSpanForKey(string key)
+        //{
+        //    return Joins.ContainsKey(key) ? Joins[key].JoinSpan : 0;
+        //}
+    }
+
+    /// <summary>
+    /// Read = Provides feedback to SIMPL
+    /// Write = Responds to sig values from SIMPL
+    /// </summary>
+    [Flags]
+    public enum eJoinCapabilities
+    {
+        None = 0,
+        ToSIMPL = 1,
+        FromSIMPL = 2,
+        ToFromSIMPL = ToSIMPL | FromSIMPL
+    }
+
+    [Flags]
+    public enum eJoinType
+    {
+        None = 0,
+        Digital = 1,
+        Analog = 2,
+        Serial = 4,
+        DigitalAnalog = Digital | Analog,
+        DigitalSerial = Digital | Serial,
+        AnalogSerial = Analog | Serial,
+        DigitalAnalogSerial = Digital | Analog | Serial
+    }
+
+    /// <summary>
+    /// Metadata describing the join
+    /// </summary>
     public class JoinMetadata
     {
-        private string _description;
-
-        /// <summary>
-        /// Join number (based on join offset value)
-        /// </summary>
-        [JsonProperty("joinNumber")]
-        [Obsolete]
-        public uint JoinNumber { get; set; }
-        /// <summary>
-        /// Join range span.  If join indicates the start of a range of joins, this indicated the maximum number of joins in the range
-        /// </summary>
-        [Obsolete]
-        [JsonProperty("joinSpan")]
-        public uint JoinSpan { get; set; }
-
-        /// <summary>
-        /// A label for the join to better describe its usage
-        /// </summary>
+        private string _description;
+
+        /// <summary>
+        /// Join number (based on join offset value)
+        /// </summary>
+        [JsonProperty("joinNumber")]
+        [Obsolete]
+        public uint JoinNumber { get; set; }
+        /// <summary>
+        /// Join range span.  If join indicates the start of a range of joins, this indicated the maximum number of joins in the range
+        /// </summary>
+        [Obsolete]
+        [JsonProperty("joinSpan")]
+        public uint JoinSpan { get; set; }
+
+        /// <summary>
+        /// A label for the join to better describe its usage
+        /// </summary>
         [Obsolete("Use Description instead")]
         [JsonProperty("label")]
-        public string Label { get { return _description; } set { _description = value; } }
-
+        public string Label { get { return _description; } set { _description = value; } }
+
         /// <summary>
         /// A description for the join to better describe its usage
-        /// </summary>
+        /// </summary>
         [JsonProperty("description")]
-        public string Description { get { return _description; } set { _description = value; } }
-        /// <summary>
-        /// Signal type(s)
-        /// </summary>
-        [JsonProperty("joinType")]
-        public eJoinType JoinType { get; set; }
-        /// <summary>
-        /// Indicates whether the join is read and/or write
-        /// </summary>
-        [JsonProperty("joinCapabilities")]
-        public eJoinCapabilities JoinCapabilities { get; set; }
-        /// <summary>
-        /// Indicates a set of valid values (particularly if this translates to an enum
-        /// </summary>
-        [JsonProperty("validValues")]
-        public string[] ValidValues { get; set; }
-
-    }
-
-    /// <summary>
-    /// Data describing the join.  Can be 
-    /// </summary>
-    public class JoinData
-    {
-        /// <summary>
-        /// Join number (based on join offset value)
-        /// </summary>
-        [JsonProperty("joinNumber")]
-        public uint JoinNumber { get; set; }
-        /// <summary>
-        /// Join range span.  If join indicates the start of a range of joins, this indicated the maximum number of joins in the range
-        /// </summary>
-        [JsonProperty("joinSpan")]
-        public uint JoinSpan { get; set; }
-    }
-
-    /// <summary>
-    /// A class to aggregate the JoinData and JoinMetadata for a join
-    /// </summary>
-    public class JoinDataComplete
-    {
-        private uint _joinOffset;
-
-        private JoinData _data;
-        public JoinMetadata Metadata { get; set; }
-
-        public JoinDataComplete(JoinData data, JoinMetadata metadata)
-        {
-            _data = data;
-            Metadata = metadata;
-        }
-
-        /// <summary>
-        /// Sets the join offset value
-        /// </summary>
-        /// <param name="joinOffset"></param>
-        public void SetJoinOffset(uint joinOffset)
-        {
-            _joinOffset = joinOffset;
-        }
-
-        /// <summary>
-        /// The join number (including the offset)
-        /// </summary>
-        public uint JoinNumber
-        {
-            get { return _data.JoinNumber+ _joinOffset; }
-            set { _data.JoinNumber = value; }
-        }
-
-        public uint JoinSpan
-        {
-            get { return _data.JoinSpan; }
-        }
-
-        public void SetCustomJoinData(JoinData customJoinData)
-        {
-            _data = customJoinData;
-        }
-
-        public string GetNameAttribute(MemberInfo memberInfo)
-        {
-            var name = string.Empty;
-            var attribute = (JoinNameAttribute)CAttribute.GetCustomAttribute(memberInfo, typeof(JoinNameAttribute));
-
-            if (attribute == null) return name;
-
-            name = attribute.Name;
-            Debug.Console(2, "JoinName Attribute value: {0}", name);
-            return name;
+        public string Description { get { return _description; } set { _description = value; } }
+        /// <summary>
+        /// Signal type(s)
+        /// </summary>
+        [JsonProperty("joinType")]
+        public eJoinType JoinType { get; set; }
+        /// <summary>
+        /// Indicates whether the join is read and/or write
+        /// </summary>
+        [JsonProperty("joinCapabilities")]
+        public eJoinCapabilities JoinCapabilities { get; set; }
+        /// <summary>
+        /// Indicates a set of valid values (particularly if this translates to an enum
+        /// </summary>
+        [JsonProperty("validValues")]
+        public string[] ValidValues { get; set; }
+
+    }
+
+    /// <summary>
+    /// Data describing the join.  Can be 
+    /// </summary>
+    public class JoinData
+    {
+        /// <summary>
+        /// Join number (based on join offset value)
+        /// </summary>
+        [JsonProperty("joinNumber")]
+        public uint JoinNumber { get; set; }
+        /// <summary>
+        /// Join range span.  If join indicates the start of a range of joins, this indicated the maximum number of joins in the range
+        /// </summary>
+        [JsonProperty("joinSpan")]
+        public uint JoinSpan { get; set; }
+    }
+
+    /// <summary>
+    /// A class to aggregate the JoinData and JoinMetadata for a join
+    /// </summary>
+    public class JoinDataComplete
+    {
+        private uint _joinOffset;
+
+        private JoinData _data;
+        public JoinMetadata Metadata { get; set; }
+
+        public JoinDataComplete(JoinData data, JoinMetadata metadata)
+        {
+            _data = data;
+            Metadata = metadata;
+        }
+
+        /// <summary>
+        /// Sets the join offset value
+        /// </summary>
+        /// <param name="joinOffset"></param>
+        public void SetJoinOffset(uint joinOffset)
+        {
+            _joinOffset = joinOffset;
+        }
+
+        /// <summary>
+        /// The join number (including the offset)
+        /// </summary>
+        public uint JoinNumber
+        {
+            get { return _data.JoinNumber+ _joinOffset; }
+            set { _data.JoinNumber = value; }
+        }
+
+        public uint JoinSpan
+        {
+            get { return _data.JoinSpan; }
+        }
+
+        public void SetCustomJoinData(JoinData customJoinData)
+        {
+            _data = customJoinData;
+        }
+
+        public string GetNameAttribute(MemberInfo memberInfo)
+        {
+            var name = string.Empty;
+            var attribute = (JoinNameAttribute)CAttribute.GetCustomAttribute(memberInfo, typeof(JoinNameAttribute));
+
+            if (attribute == null) return name;
+
+            name = attribute.Name;
+            Debug.Console(2, "JoinName Attribute value: {0}", name);
+            return name;
         }
     }
 
-    
-
-    [AttributeUsage(AttributeTargets.All)]
-    public class JoinNameAttribute : CAttribute
-    {
-        private string _Name;
-
-        public JoinNameAttribute(string name)
-        {
-            Debug.Console(2, "Setting Attribute Name: {0}", name);
-            _Name = name;
-        }
-
-        public string Name
-        {
-            get { return _Name; }
-        }
+    
+
+    [AttributeUsage(AttributeTargets.All)]
+    public class JoinNameAttribute : CAttribute
+    {
+        private string _Name;
+
+        public JoinNameAttribute(string name)
+        {
+            Debug.Console(2, "Setting Attribute Name: {0}", name);
+            _Name = name;
+        }
+
+        public string Name
+        {
+            get { return _Name; }
+        }
     }
 }

essentials-framework/Essentials Core/PepperDashEssentialsBase/PepperDash_Essentials_Core.csproj

@@ -137,7 +137,6 @@
     <Compile Include="Bridges\JoinMaps\GenericLightingJoinMap.cs" />
     <Compile Include="Bridges\JoinMaps\GenericRelayControllerJoinMap.cs" />
     <Compile Include="Bridges\JoinMaps\GlsOccupancySensorBaseJoinMap.cs" />
-    <Compile Include="Bridges\JoinMaps\GlsPartitionSensorJoinMap.cs" />
     <Compile Include="Bridges\JoinMaps\HdMdNxM4kEControllerJoinMap.cs" />
     <Compile Include="Bridges\JoinMaps\HdMdxxxCEControllerJoinMap.cs" />
     <Compile Include="Bridges\JoinMaps\Hrxxx0WirelessRemoteControllerJoinMap.cs" />

essentials-framework/Essentials Core/PepperDashEssentialsBase/Remotes/Hrxx0WirelessRemoteController.cs

@@ -112,29 +112,17 @@ namespace PepperDash.Essentials.Core
                 return null;
             }
 
-            Hr1x0WirelessRemoteBase remoteBase;
             switch (type)
             {
                 case ("hr100"):
-                    remoteBase = new Hr100(rfId, gateway);
-                    break;
+                    return new Hr100(rfId, gateway);
                 case ("hr150"):
-                    remoteBase = new Hr150(rfId, gateway);
-                    break;
+                    return new Hr150(rfId, gateway);
                 case ("hr310"):
-                    remoteBase = new Hr310(rfId, gateway);
-                    break;
+                    return new Hr310(rfId, gateway);
                 default:
                     return null;
             }
-
-            // register the device when using an internal RF gateway
-            if (props.GatewayDeviceKey == "processor")
-            {
-                remoteBase.RegisterWithLogging(config.Key);
-            }
-
-            return remoteBase;            
         }
 
         static void gateway_BaseEvent(GenericBase device, BaseEventArgs args)
@@ -261,4 +249,4 @@ namespace PepperDash.Essentials.Core
             trilist.BooleanInput[join].BoolValue = b;
         }
     }
-}
+}

essentials-framework/Essentials Devices Common/Essentials Devices Common/Essentials Devices Common.csproj

@@ -116,8 +116,6 @@
     <Compile Include="ImageProcessors\TVOneCorioPropertiesConfig.cs" />
     <Compile Include="Occupancy\CenOdtOccupancySensorBaseController.cs" />
     <Compile Include="Occupancy\GlsOdtOccupancySensorController.cs" />
-    <Compile Include="PartitionSensor\GlsPartitionSensorController.cs" />
-    <Compile Include="PartitionSensor\GlsPartitionSensorControllerFactory.cs" />
     <Compile Include="Power Controllers\Digitallogger.cs" />
     <Compile Include="Power Controllers\DigitalLoggerPropertiesConfig.cs" />
     <Compile Include="ImageProcessors\AnalogWay\AnalongWayLiveCore.cs" />

essentials-framework/Essentials Devices Common/Essentials Devices Common/PartitionSensor/GlsPartitionSensorController.cs

@@ -1,257 +0,0 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using Crestron.SimplSharp;
-using Crestron.SimplSharpPro;
-using Crestron.SimplSharpPro.DeviceSupport;
-using Crestron.SimplSharpPro.GeneralIO;
-using Newtonsoft.Json;
-using PepperDash.Core;
-using PepperDash.Essentials.Core;
-using PepperDash.Essentials.Core.Config;
-using PepperDash.Essentials.Core.Bridges;
-using PepperDash_Essentials_Core.Bridges.JoinMaps;
-
-namespace PepperDash.Essentials.Devices.Common.PartitionSensor
-{
-	[Description("Wrapper class for GLS Cresnet Partition Sensor")]
-	public class GlsPartitionSensorController : CrestronGenericBridgeableBaseDevice
-	{
-		public GlsPartCn PartitionSensor { get; private set; }
-
-		public StringFeedback NameFeedback { get; private set; }
-
-		public BoolFeedback EnableFeedback { get; private set; }
-
-		public BoolFeedback PartitionSensedFeedback { get; private set; }
-		public BoolFeedback PartitionNotSensedFeedback { get; private set; }
-
-		public IntFeedback SensitivityFeedback { get; private set; }
-
-		public bool InTestMode { get; private set; }
-		public bool TestEnableFeedback { get; private set; }
-		public bool TestPartitionSensedFeedback { get; private set; }
-		public int TestSensitivityFeedback { get; private set; }
-
-		public Func<string> NameFeedbackFunc
-		{
-			get { return () => Name; }
-		}
-
-		public Func<bool> EnableFeedbackFunc
-		{
-			get { return () => InTestMode ? TestEnableFeedback : PartitionSensor.EnableFeedback.BoolValue; }
-		}
-
-		public Func<bool> PartitionSensedFeedbackFunc
-		{
-			get { return () => InTestMode ? TestPartitionSensedFeedback : PartitionSensor.PartitionSensedFeedback.BoolValue; }
-		}
-
-		public Func<bool> PartitionNotSensedFeedbackFunc
-		{
-			get { return () => InTestMode ? TestPartitionSensedFeedback : PartitionSensor.PartitionNotSensedFeedback.BoolValue; }
-		}
-
-		public Func<int> SensitivityFeedbackFunc
-		{
-			get { return () => InTestMode ? TestSensitivityFeedback : PartitionSensor.SensitivityFeedback.UShortValue; }
-		}
-
-		/// <summary>
-		/// Constructor
-		/// </summary>
-		/// <param name="key"></param>
-		/// <param name="name"></param>
-		/// <param name="hardware"></param>
-		public GlsPartitionSensorController(string key, string name, GlsPartCn hardware)
-			: base(key, name, hardware)
-		{
-			PartitionSensor = hardware;
-
-			NameFeedback = new StringFeedback(NameFeedbackFunc);
-			EnableFeedback = new BoolFeedback(EnableFeedbackFunc);
-			PartitionSensedFeedback = new BoolFeedback(PartitionSensedFeedbackFunc);
-			PartitionNotSensedFeedback = new BoolFeedback(PartitionNotSensedFeedbackFunc);
-			SensitivityFeedback = new IntFeedback(SensitivityFeedbackFunc);
-
-			if (PartitionSensor != null) PartitionSensor.BaseEvent += PartitionSensor_BaseEvent;
-		}
-
-
-		private void PartitionSensor_BaseEvent(GenericBase device, BaseEventArgs args)
-		{
-			Debug.Console(2, this, "EventId: {0}, Index: {1}", args.EventId, args.Index);
-
-			switch (args.EventId)
-			{
-				case (GlsPartCn.EnableFeedbackEventId):
-					{
-						EnableFeedback.FireUpdate();
-						break;
-					}
-				case (GlsPartCn.PartitionSensedFeedbackEventId):
-					{
-						PartitionSensedFeedback.FireUpdate();
-						break;
-					}
-				case (GlsPartCn.PartitionNotSensedFeedbackEventId):
-					{
-						PartitionNotSensedFeedback.FireUpdate();
-						break;
-					}
-				case (GlsPartCn.SensitivityFeedbackEventId):
-					{
-						SensitivityFeedback.FireUpdate();
-						break;
-					}
-				default:
-					{
-						Debug.Console(2, this, "args.EventId: {0}", args.EventId);
-						break;
-					}
-			}
-		}
-
-		public void SetTestMode(bool mode)
-		{
-			InTestMode = mode;
-			Debug.Console(1, this, "InTestMode: {0}", InTestMode.ToString());
-		}
-
-		public void SetTestEnableState(bool state)
-		{
-			if (InTestMode)
-			{
-				TestEnableFeedback = state;
-				Debug.Console(1, this, "TestEnableFeedback: {0}", TestEnableFeedback.ToString());
-				return;
-			}
-
-			Debug.Console(1, this, "InTestMode: {0}, unable to set enable state: {1}", InTestMode.ToString(), state.ToString());
-		}
-
-		public void SetTestPartitionSensedState(bool state)
-		{
-			if (InTestMode)
-			{
-				TestPartitionSensedFeedback = state;
-				Debug.Console(1, this, "TestPartitionSensedFeedback: {0}", TestPartitionSensedFeedback.ToString());
-				return;
-			}
-
-			Debug.Console(1, this, "InTestMode: {0}, unable to set partition state: {1}", InTestMode.ToString(), state.ToString());
-		}
-
-		public void SetTestSensitivityValue(int value)
-		{
-			if (InTestMode)
-			{
-				TestSensitivityFeedback = value;
-				Debug.Console(1, this, "TestSensitivityFeedback: {0}", TestSensitivityFeedback);
-				return;
-			}
-
-			Debug.Console(1, this, "InTestMode: {0}, unable to set sensitivity value: {1}", InTestMode.ToString(), value);
-		}
-
-		public void SetEnableState(bool state)
-		{
-			if (PartitionSensor == null)
-				return;
-
-			PartitionSensor.Enable.BoolValue = state;
-		}
-
-		public void IncreaseSensitivity()
-		{
-			if (PartitionSensor == null)
-				return;
-
-			PartitionSensor.IncreaseSensitivity();
-		}
-
-		public void DecreaseSensitivity()
-		{
-			if (PartitionSensor == null)
-				return;
-
-			PartitionSensor.DecreaseSensitivity();
-		}
-
-		public void SetSensitivity(ushort value)
-		{
-			if (PartitionSensor == null)
-				return;
-
-			PartitionSensor.Sensitivity.UShortValue = (ushort)value;
-		}
-
-
-		public override void LinkToApi(BasicTriList trilist, uint joinStart, string joinMapKey, EiscApiAdvanced bridge)
-		{
-			var joinMap = new GlsPartitionSensorJoinMap(joinStart);
-			var joinMapSerialized = JoinMapHelper.GetSerializedJoinMapForDevice(joinMapKey);
-
-			if (!string.IsNullOrEmpty(joinMapSerialized))
-				joinMap = JsonConvert.DeserializeObject<GlsPartitionSensorJoinMap>(joinMapSerialized);
-
-			if (bridge != null)
-			{
-				bridge.AddJoinMap(Key, joinMap);
-			}
-			else
-			{
-				Debug.Console(0, this, "Please update config to use 'type': 'EiscApiAdvanced' to get all join map features for this device");
-			}
-
-			Debug.Console(1, this, "Linking to Trilist '{0}'", trilist.ID.ToString("X"));
-			Debug.Console(0, this, "Linking to Bridge Type {0}", GetType().Name);
-
-			// link input from simpl
-			trilist.SetSigTrueAction(joinMap.Enable.JoinNumber, () => SetEnableState(true));
-			trilist.SetSigFalseAction(joinMap.Enable.JoinNumber, () => SetEnableState(false));
-			trilist.SetSigTrueAction(joinMap.IncreaseSensitivity.JoinNumber, IncreaseSensitivity);
-			trilist.SetSigTrueAction(joinMap.DecreaseSensitivity.JoinNumber, DecreaseSensitivity);
-			trilist.SetUShortSigAction(joinMap.Sensitivity.JoinNumber, SetSensitivity);
-
-			// link output to simpl
-			IsOnline.LinkInputSig(trilist.BooleanInput[joinMap.IsOnline.JoinNumber]);
-			EnableFeedback.LinkInputSig(trilist.BooleanInput[joinMap.Enable.JoinNumber]);
-			PartitionSensedFeedback.LinkInputSig(trilist.BooleanInput[joinMap.PartitionSensed.JoinNumber]);
-			PartitionNotSensedFeedback.LinkComplementInputSig(trilist.BooleanInput[joinMap.PartitionNotSensed.JoinNumber]);
-			SensitivityFeedback.LinkInputSig(trilist.UShortInput[joinMap.Sensitivity.JoinNumber]);
-
-			FeedbacksFireUpdates();
-
-			// update when device is online
-			PartitionSensor.OnlineStatusChange += (o, a) =>
-			{
-				if (a.DeviceOnLine)
-				{
-					FeedbacksFireUpdates();
-				}
-			};
-
-			// update when trilist is online
-			trilist.OnlineStatusChange += (o, a) =>
-			{
-				if (a.DeviceOnLine)
-				{
-					FeedbacksFireUpdates();
-				}
-			};
-		}
-
-		private void FeedbacksFireUpdates()
-		{
-			IsOnline.FireUpdate();
-			NameFeedback.FireUpdate();
-			EnableFeedback.FireUpdate();
-			PartitionSensedFeedback.FireUpdate();
-			PartitionNotSensedFeedback.FireUpdate();
-			SensitivityFeedback.FireUpdate();
-		}
-	}
-}

essentials-framework/Essentials Devices Common/Essentials Devices Common/PartitionSensor/GlsPartitionSensorControllerFactory.cs

@@ -1,39 +0,0 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using Crestron.SimplSharp;
-using Crestron.SimplSharpPro.GeneralIO;
-using PepperDash.Core;
-using PepperDash.Essentials.Core;
-using PepperDash.Essentials.Core.Config;
-using PepperDash.Essentials.Devices.Common.Occupancy;
-
-namespace PepperDash.Essentials.Devices.Common.PartitionSensor
-{
-	public class GlsPartitionSensorControllerFactory : EssentialsDeviceFactory<GlsPartitionSensorController>
-	{
-		public GlsPartitionSensorControllerFactory()
-		{
-			TypeNames = new List<string>() { "glspartcn" };
-		}
-
-		public override EssentialsDevice BuildDevice(DeviceConfig dc)
-		{
-			Debug.Console(2, "Factory Attempting to create new GLS-PART-CN Device");
-
-			var typeName = dc.Type.ToLower();
-			var key = dc.Key;
-			var name = dc.Name;
-			var comm = CommFactory.GetControlPropertiesConfig(dc);
-			if (comm == null)
-			{
-				Debug.Console(0, "ERROR: Control Properties Config are null");
-				return null;
-			}
-
-			var sensor = new GlsPartCn(comm.CresnetIdInt, Global.ControlSystem);
-			return new GlsPartitionSensorController(dc.Key, dc.Name, sensor);
-		}
-	}
-}

essentials-framework/Essentials Devices Common/Essentials Devices Common/VideoCodec/CiscoCodec/CiscoSparkCodec.cs

@@ -1658,7 +1658,7 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.Cisco
             {
                 get
                 {
-                    if (CodecStatus.Status.SIP.Registration.Count > 0)
+                    if (CodecStatus.Status.SIP != null && CodecStatus.Status.SIP.Registration.Count > 0)
                     {
                         var match = Regex.Match(CodecStatus.Status.SIP.Registration[0].URI.Value, @"(\d+)"); // extract numbers only
                         if (match.Success)
@@ -1678,17 +1678,26 @@ namespace PepperDash.Essentials.Devices.Common.VideoCodec.Cisco
                         return string.Empty;
                     }
                 }
-            }
-            public override string SipUri
-            {
-                get
-                {
-                    if (CodecStatus.Status.SIP.AlternateURI.Primary.URI.Value != null)
-                        return CodecStatus.Status.SIP.AlternateURI.Primary.URI.Value;
-                    else
-                        return string.Empty;
-                }
-            }
+            }
+
+            public override string SipUri
+            {
+                get
+                {
+                    if (CodecStatus.Status.SIP != null && CodecStatus.Status.SIP.AlternateURI.Primary.URI.Value != null)
+                    {
+                        return CodecStatus.Status.SIP.AlternateURI.Primary.URI.Value;
+                    }
+                    else if (CodecStatus.Status.UserInterface != null &&
+                             CodecStatus.Status.UserInterface.ContactInfo.ContactMethod[0].Number.Value != null)
+                    {
+                        return CodecStatus.Status.UserInterface.ContactInfo.ContactMethod[0].Number.Value;
+                    }
+                    else
+                        return string.Empty;
+                }
+            }
+
             public override bool AutoAnswerEnabled
             {
                 get