Merge pull request #528 from PepperDash/feature/update-plugin-dependency-check

Update Plugin Dependency Check

essentials-framework/Essentials Core/PepperDashEssentialsBase/Display/BasicIrDisplay.cs

@@ -20,7 +20,8 @@ namespace PepperDash.Essentials.Core
 		public IrOutputPortController IrPort { get; private set; }
 		public ushort IrPulseTime { get; set; }
 
-        public BoolFeedback PowerIsOnFeedback { get; private set; }
+        [Obsolete("This property will be removed in version 2.0.0")]
+        public override BoolFeedback PowerIsOnFeedback { get; protected set; }
 
         protected Func<bool> PowerIsOnFeedbackFunc
         {

essentials-framework/Essentials Core/PepperDashEssentialsBase/Display/DisplayBase.cs

@@ -18,7 +18,7 @@ namespace PepperDash.Essentials.Core
 	/// <summary>
 	/// 
 	/// </summary>
-    public abstract class DisplayBase : EssentialsDevice, IHasFeedback, IRoutingSinkWithSwitching, IHasPowerControl, IWarmingCooling, IUsageTracking
+    public abstract class DisplayBase : EssentialsDevice, IHasFeedback, IRoutingSinkWithSwitching, IHasPowerControl, IWarmingCooling, IUsageTracking, IPower
 	{
         public event SourceInfoChangeHandler CurrentSourceChange;
 
@@ -49,6 +49,9 @@ namespace PepperDash.Essentials.Core
 		public BoolFeedback IsCoolingDownFeedback { get; protected set; }
 		public BoolFeedback IsWarmingUpFeedback { get; private set; }
 
+        [Obsolete("This property will be removed in version 2.0.0")]
+        public abstract BoolFeedback PowerIsOnFeedback { get; protected set; }
+
         public UsageTracking UsageTracker { get; set; }
 
 		public uint WarmupTime { get; set; }
@@ -261,7 +264,8 @@ namespace PepperDash.Essentials.Core
 
         abstract protected Func<string> CurrentInputFeedbackFunc { get; }
 
-        public BoolFeedback PowerIsOnFeedback { get; protected set; }
+        public override BoolFeedback PowerIsOnFeedback { get; protected set; }
+
         abstract protected Func<bool> PowerIsOnFeedbackFunc { get; }
 
 

essentials-framework/Essentials Core/PepperDashEssentialsBase/Plugins/PluginLoader.cs

@@ -402,13 +402,16 @@ namespace PepperDash.Essentials
         /// Loads a
         /// </summary>
         /// <param name="plugin"></param>
+        /// <param name="loadedAssembly"></param>
         static void LoadCustomPlugin(IPluginDeviceFactory plugin, LoadedAssembly loadedAssembly)
         {
             var passed = Global.IsRunningMinimumVersionOrHigher(plugin.MinimumEssentialsFrameworkVersion);
 
             if (!passed)
             {
-                Debug.Console(0, Debug.ErrorLogLevel.Error, "Plugin indicates minimum Essentials version {0}.  Dependency check failed.  Skipping Plugin", plugin.MinimumEssentialsFrameworkVersion);
+                Debug.Console(0, Debug.ErrorLogLevel.Error,
+                    "\r\n********************\r\n\tPlugin indicates minimum Essentials version {0}.  Dependency check failed.  Skipping Plugin {1}\r\n********************",
+                    plugin.MinimumEssentialsFrameworkVersion, loadedAssembly.Name);
                 return;
             }
             else

essentials-framework/Essentials DM/Essentials_DM/Chassis/DmChassisController.cs

@@ -320,7 +320,7 @@ namespace PepperDash.Essentials.DM
 
                             if (outputCard.Card is DmcStroAV)
                             {
-                                Debug.Console(0, "Found output stream card in slot: {0}.", tempX);
+                                Debug.Console(2, "Found output stream card in slot: {0}.", tempX);
                                 var streamCard = outputCard.Card as DmcStroAV;
                                 if (streamCard.Control.StartFeedback.BoolValue == true)
                                     return 1;
@@ -446,7 +446,7 @@ namespace PepperDash.Essentials.DM
 
                             if (inputCard.Card is DmcStr)
                             {
-                                Debug.Console(0, "Found input stream card in slot: {0}.", tempX);
+                                Debug.Console(2, "Found input stream card in slot: {0}.", tempX);
                                 var streamCard = inputCard.Card as DmcStr;
                                 if (streamCard.Control.StartFeedback.BoolValue == true)
                                     return 1;
@@ -981,33 +981,10 @@ namespace PepperDash.Essentials.DM
                             Debug.Console(2, this, "DM Input {0} Stream Status EventId", args.Number);
                             if (InputStreamCardStateFeedbacks[args.Number] != null)
                             {
-                                var streamCard = Chassis.Inputs[args.Number].Card as DmcStr;
-                                InputStreamCardStateFeedbacks[args.Number] = new IntFeedback(() => {
-                                    if (streamCard.Control.StartFeedback.BoolValue == true)
-                                    {
-                                        Debug.Console(1, this, "Found start feedback");
-                                        return 1;
-                                    }
-                                    else if (streamCard.Control.StopFeedback.BoolValue == true)
-                                    {
-                                        Debug.Console(1, this, "Found stop feedback");
-                                        return 2;
-                                    }
-                                    else if (streamCard.Control.PauseFeedback.BoolValue == true)
-                                    {
-                                        Debug.Console(1, this, "Found pause feedback");
-                                        return 3;
-                                    }
-                                    else
-                                    {
-                                        Debug.Console(1, this, "Found no feedback");
-                                        return 0;
-                                    }
-                                });
                                 InputStreamCardStateFeedbacks[args.Number].FireUpdate();
                             }
                             else
-                                Debug.Console(1, this, "No index of {0} found in InputStreamCardStateFeedbacks");
+                                Debug.Console(2, this, "No index of {0} found in InputStreamCardStateFeedbacks");
                             break;
                         }
                     default:
@@ -1145,22 +1122,10 @@ namespace PepperDash.Essentials.DM
                     Debug.Console(2, this, "DM Output {0} Stream Status EventId", args.Number);
                     if (OutputStreamCardStateFeedbacks[args.Number] != null)
                     {
-                        var streamCard = Chassis.Outputs[args.Number].Card as DmcStroAV;
-                        OutputStreamCardStateFeedbacks[args.Number] = new IntFeedback(() =>
-                        {
-                            if (streamCard.Control.StartFeedback.BoolValue == true)
-                                return 1;
-                            else if (streamCard.Control.StopFeedback.BoolValue == true)
-                                return 2;
-                            else if (streamCard.Control.PauseFeedback.BoolValue == true)
-                                return 3;
-                            else
-                                return 0;
-                        });
                         OutputStreamCardStateFeedbacks[args.Number].FireUpdate();
                     }
                     else
-                        Debug.Console(1, this, "No index of {0} found in OutputStreamCardStateFeedbacks");
+                        Debug.Console(2, this, "No index of {0} found in OutputStreamCardStateFeedbacks");
                     break;
                 }
                 default: