Merge pull request #1304 from PepperDash/temp-to-dev

Temp to dev

src/Directory.Build.props

@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
-    <Version>2.12.1-local</Version>
+    <Version>2.4.0-local</Version>
     <InformationalVersion>$(Version)</InformationalVersion>
     <Authors>PepperDash Technology</Authors>
     <Company>PepperDash Technology</Company>

src/PepperDash.Essentials.Core/Config/BaseStreamingDeviceProperties.cs

@@ -1,23 +0,0 @@
-using System;
-using Newtonsoft.Json;
-
-namespace PepperDash.Essentials.Core.Config
-{
-  /// <summary>
-  /// Represents the base properties for a streaming device.
-  /// </summary>
-  public class BaseStreamingDeviceProperties
-  {
-    /// <summary>
-    /// The multicast video address for the streaming device.
-    /// </summary>
-    [JsonProperty("multicastVideoAddress", NullValueHandling = NullValueHandling.Ignore)]
-    public string MulticastVideoAddress { get; set; }
-
-    /// <summary>
-    /// The multicast audio address for the streaming device.
-    /// </summary>
-    [JsonProperty("multicastAudioAddress", NullValueHandling = NullValueHandling.Ignore)]
-    public string MulticastAudioAddress { get; set; }
-  }
-}

src/PepperDash.Essentials.Core/Devices/SourceListItem.cs

@@ -244,20 +244,6 @@ namespace PepperDash.Essentials.Core
         /// </summary>
         [JsonProperty("type")]
         public eRoutingSignalType Type { get; set; }
-
-        /// <summary>
-        /// Key for a destination list item. If BOTH SourceListItemKey AND DestinationListItemKey are defined,
-        /// then the direct route method should be used.
-        /// </summary>
-        [JsonProperty("destinationListItemKey", NullValueHandling = NullValueHandling.Ignore)]
-        public string DestinationListItemKey { get; set; }
-
-        /// <summary>
-        /// Key for a source list item. If BOTH SourceListItemKey AND DestinationListItemKey are defined,
-        /// then the direct route method should be used.
-        /// </summary>
-        [JsonProperty("sourceListItemKey", NullValueHandling = NullValueHandling.Ignore)]
-        public string SourceListItemKey { get; set; }
     }
 
     /// <summary>

src/PepperDash.Essentials.Core/Factory/DeviceFactory.cs

@@ -135,7 +135,7 @@ namespace PepperDash.Essentials.Core
         {
             if (FactoryMethods.ContainsKey(typeName))
             {
-                Debug.LogInformation("Unable to add type: '{typeName}'. Already exists in DeviceFactory", typeName);
+                Debug.LogInformation("Unable to add type: '{typeName}'.  Already exists in DeviceFactory", typeName);
                 return;
             }
 
@@ -217,8 +217,7 @@ namespace PepperDash.Essentials.Core
             }
             catch (Exception ex)
             {
-                Debug.LogError(ex, "Exception occurred while creating device {key}: {message}", dc.Key, ex.Message);
-                Debug.LogDebug(ex, "Exception details: {stackTrace}", ex.StackTrace);
+                Debug.LogError(ex, "Exception occurred while creating device {0}: {1}", null, dc.Key, ex.Message);
                 return null;
             }
         }

src/PepperDash.Essentials.Core/Routing/ICurrentSources.cs

@@ -1,5 +1,5 @@
-using System;
 using System.Collections.Generic;
+using PepperDash.Essentials.Core;
 
 namespace PepperDash.Essentials.Core.Routing
 {
@@ -25,19 +25,5 @@ namespace PepperDash.Essentials.Core.Routing
     /// </summary>
     Dictionary<eRoutingSignalType, string> CurrentSourceKeys { get; }
 
-    /// <summary>
-    /// Event raised when the current sources change.
-    /// </summary>
-    event EventHandler CurrentSourcesChanged;
-
-    /// <summary>
-    /// Sets the current source for a specific signal type.
-    /// This method updates the current source for the specified signal type and notifies any subscribers of the change.
-    /// </summary>
-    /// <param name="signalType">The signal type to update.</param>
-    /// <param name="sourceListKey">The key for the source list.</param>
-    /// <param name="sourceListItem">The source list item to set as the current source.</param>
-    void SetCurrentSource(eRoutingSignalType signalType, string sourceListKey, SourceListItem sourceListItem);
-
   }
 }

src/PepperDash.Essentials.Core/Routing/TieLineConfig.cs

@@ -22,38 +22,38 @@ namespace PepperDash.Essentials.Core.Config
 		/// The key of the source device.
 		/// </summary>
 		public string SourceKey { get; set; }
-
-		/// <summary>
-		/// The key of the source card (if applicable, e.g., in a modular chassis).
-		/// </summary>
+		
+  /// <summary>
+  /// The key of the source card (if applicable, e.g., in a modular chassis).
+  /// </summary>
 		public string SourceCard { get; set; }
-
-		/// <summary>
-		/// The key of the source output port, used for routing configurations.
-		/// </summary>
+		
+  /// <summary>
+  /// The key of the source output port, used for routing configurations.
+  /// </summary>
 		public string SourcePort { get; set; }
-
-		/// <summary>
-		/// Gets or sets the DestinationKey
-		/// </summary>
+		
+  /// <summary>
+  /// Gets or sets the DestinationKey
+  /// </summary>
 		public string DestinationKey { get; set; }
-
-		/// <summary>
-		/// Gets or sets the DestinationCard
-		/// </summary>
+		
+  /// <summary>
+  /// Gets or sets the DestinationCard
+  /// </summary>
 		public string DestinationCard { get; set; }
-
-		/// <summary>
-		/// Gets or sets the DestinationPort
-		/// </summary>
+		
+  /// <summary>
+  /// Gets or sets the DestinationPort
+  /// </summary>
 		public string DestinationPort { get; set; }
 
-		/// <summary>
-		/// Optional override for the signal type of the tie line. If set, this overrides the destination port's type for routing calculations.
-		/// </summary>
-		[JsonProperty("type", NullValueHandling = NullValueHandling.Ignore)]
-		[JsonConverter(typeof(StringEnumConverter))]
-		public eRoutingSignalType? OverrideType { get; set; }
+        /// <summary>
+        /// Optional override for the signal type of the tie line. If set, this overrides the destination port's type for routing calculations.
+        /// </summary>
+        [JsonProperty("type", NullValueHandling = NullValueHandling.Ignore)]
+        [JsonConverter(typeof(StringEnumConverter))]
+        public eRoutingSignalType? OverrideType { get; set; }
 
 		/// <summary>
 		/// Returns the appropriate tie line for either a card-based device or 
@@ -62,39 +62,40 @@ namespace PepperDash.Essentials.Core.Config
 		/// <returns>null if config data does not match ports, cards or devices</returns>
 		public TieLine GetTieLine()
 		{
-			Debug.LogInformation("Build TieLine: {config}", ToString());
-
+			Debug.LogMessage(LogEventLevel.Information, "Build TieLine: {0}",null, this);
 			// Get the source device
-			if (!(DeviceManager.GetDeviceForKey(SourceKey) is IRoutingOutputs sourceDev))
+			var sourceDev = DeviceManager.GetDeviceForKey(SourceKey) as IRoutingOutputs;
+			if (sourceDev == null)
 			{
 				LogError("Routable source not found");
 				return null;
 			}
 
 			// Get the destination device
-			if (!(DeviceManager.GetDeviceForKey(DestinationKey) is IRoutingInputs destDev))
+			var destDev = DeviceManager.GetDeviceForKey(DestinationKey) as IRoutingInputs;
+			if (destDev == null)
 			{
 				LogError("Routable destination not found");
 				return null;
 			}
 
-			//Get the source port
-			var sourceOutputPort = sourceDev.OutputPorts[SourcePort];
+            //Get the source port
+            var sourceOutputPort = sourceDev.OutputPorts[SourcePort];
 
-			if (sourceOutputPort == null)
+            if (sourceOutputPort == null)
 			{
 				LogError("Source does not contain port");
 				return null;
 			}
 
-			//Get the Destination port
-			var destinationInputPort = destDev.InputPorts[DestinationPort];
+            //Get the Destination port
+            var destinationInputPort = destDev.InputPorts[DestinationPort];
 
-			if (destinationInputPort == null)
-			{
-				LogError("Destination does not contain port");
-				return null;
-			}
+            if (destinationInputPort == null)
+				{
+					LogError("Destination does not contain port");
+					return null;
+				}            
 
 			return new TieLine(sourceOutputPort, destinationInputPort, OverrideType);
 		}
@@ -103,9 +104,9 @@ namespace PepperDash.Essentials.Core.Config
 		/// Logs an error message related to creating this tie line configuration.
 		/// </summary>
 		/// <param name="msg">The specific error message.</param>
-		private void LogError(string msg)
+		void LogError(string msg)
 		{
-			Debug.LogError("Cannot create tie line: {message}", msg);
+			Debug.LogMessage(LogEventLevel.Error, "WARNING: Cannot create tie line: {message}:\r   {tieLineConfig}",null, msg, this);
 		}
 
 		/// <summary>
@@ -114,7 +115,8 @@ namespace PepperDash.Essentials.Core.Config
 		/// <returns>A string describing the source and destination of the configured tie line.</returns>
 		public override string ToString()
 		{
-			return $"{SourceKey}.{SourceCard}.{SourcePort} --> {DestinationKey}.{DestinationCard}.{DestinationPort}";
+			return string.Format("{0}.{1}.{2} --> {3}.{4}.{5}", SourceKey, SourceCard, SourcePort,
+				DestinationKey, DestinationCard, DestinationPort);
 		}
 	}
 }

src/PepperDash.Essentials.Devices.Common/Displays/DisplayBase.cs

@@ -1,12 +1,10 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Runtime.InteropServices;
 using Crestron.SimplSharp;
 using Crestron.SimplSharpPro.DeviceSupport;
 using Newtonsoft.Json;
 using PepperDash.Core;
-using PepperDash.Core.Logging;
 using PepperDash.Essentials.Core;
 using PepperDash.Essentials.Core.Bridges;
 using PepperDash.Essentials.Core.DeviceTypeInterfaces;
@@ -54,9 +52,9 @@ namespace PepperDash.Essentials.Devices.Common.Displays
 		/// </summary>
 		public event SourceInfoChangeHandler CurrentSourceChange;
 
-		/// <summary>
-		/// Gets or sets the CurrentSourceInfoKey
-		/// </summary>
+  /// <summary>
+  /// Gets or sets the CurrentSourceInfoKey
+  /// </summary>
 		public string CurrentSourceInfoKey { get; set; }
 
 		/// <summary>
@@ -91,32 +89,29 @@ namespace PepperDash.Essentials.Devices.Common.Displays
 		/// <inheritdoc/>
 		public Dictionary<eRoutingSignalType, string> CurrentSourceKeys { get; private set; }
 
-		/// <inheritdoc />
-		public event EventHandler CurrentSourcesChanged;
-
 		/// <summary>
 		/// Gets feedback indicating whether the display is currently cooling down after being powered off.
 		/// </summary>
 		public BoolFeedback IsCoolingDownFeedback { get; protected set; }
 
-		/// <summary>
-		/// Gets or sets the IsWarmingUpFeedback
-		/// </summary>
+  /// <summary>
+  /// Gets or sets the IsWarmingUpFeedback
+  /// </summary>
 		public BoolFeedback IsWarmingUpFeedback { get; private set; }
 
-		/// <summary>
-		/// Gets or sets the UsageTracker
-		/// </summary>
+  /// <summary>
+  /// Gets or sets the UsageTracker
+  /// </summary>
 		public UsageTracking UsageTracker { get; set; }
 
-		/// <summary>
-		/// Gets or sets the WarmupTime
-		/// </summary>
+  /// <summary>
+  /// Gets or sets the WarmupTime
+  /// </summary>
 		public uint WarmupTime { get; set; }
 
-		/// <summary>
-		/// Gets or sets the CooldownTime
-		/// </summary>
+  /// <summary>
+  /// Gets or sets the CooldownTime
+  /// </summary>
 		public uint CooldownTime { get; set; }
 
 		/// <summary>
@@ -194,7 +189,7 @@ namespace PepperDash.Essentials.Devices.Common.Displays
 		/// <summary>
 		/// Gets the collection of feedback objects for this display device.
 		/// </summary>
-		/// <inheritdoc />
+  /// <inheritdoc />
 		public virtual FeedbackCollection<Feedback> Feedbacks
 		{
 			get
@@ -383,51 +378,6 @@ namespace PepperDash.Essentials.Devices.Common.Displays
 			volumeDisplayWithFeedback.MuteFeedback.LinkComplementInputSig(trilist.BooleanInput[joinMap.VolumeMuteOff.JoinNumber]);
 		}
 
-		/// <inheritdoc />
-		public virtual void SetCurrentSource(eRoutingSignalType signalType, string sourceListKey, SourceListItem sourceListItem)
-		{
-			foreach (eRoutingSignalType type in Enum.GetValues(typeof(eRoutingSignalType)))
-			{
-				var flagValue = Convert.ToInt32(type);
-				if (flagValue == 0 || (flagValue & (flagValue - 1)) != 0)
-				{
-					this.LogDebug("Skipping {type}", type);
-					continue;
-				}
-
-				this.LogDebug("setting {type}", type);
-
-				if (signalType.HasFlag(type))
-				{
-					UpdateCurrentSources(type, sourceListKey, sourceListItem);
-				}
-			}
-			// Raise the CurrentSourcesChanged event
-			CurrentSourcesChanged?.Invoke(this, EventArgs.Empty);
-		}
-
-		private void UpdateCurrentSources(eRoutingSignalType signalType, string sourceListKey, SourceListItem sourceListItem)
-		{
-			if (CurrentSources.ContainsKey(signalType))
-			{
-				CurrentSources[signalType] = sourceListItem;
-			}
-			else
-			{
-				CurrentSources.Add(signalType, sourceListItem);
-			}
-
-			// Update the current source key for the specified signal type
-			if (CurrentSourceKeys.ContainsKey(signalType))
-			{
-				CurrentSourceKeys[signalType] = sourceListKey;
-			}
-			else
-			{
-				CurrentSourceKeys.Add(signalType, sourceListKey);
-			}
-		}
-
 	}
 
 	/// <summary>

src/PepperDash.Essentials.MobileControl.Messengers/Messengers/CurrentSourcesMessenger.cs

@@ -1,77 +0,0 @@
-using System.Collections.Generic;
-using Newtonsoft.Json;
-using Newtonsoft.Json.Converters;
-using Newtonsoft.Json.Linq;
-using PepperDash.Core;
-using PepperDash.Essentials.Core;
-using PepperDash.Essentials.Core.Routing;
-
-namespace PepperDash.Essentials.AppServer.Messengers
-{
-  /// <summary>
-  /// Represents a IHasCurrentSourceInfoMessenger
-  /// </summary>
-  public class CurrentSourcesMessenger : MessengerBase
-  {
-    private readonly ICurrentSources sourceDevice;
-
-    /// <summary>
-    /// Initializes a new instance of the <see cref="CurrentSourcesMessenger"/> class.
-    /// </summary>
-    /// <param name="key">The key.</param>
-    /// <param name="messagePath">The message path.</param>
-    /// <param name="device">The device.</param>
-    public CurrentSourcesMessenger(string key, string messagePath, ICurrentSources device) : base(key, messagePath, device as IKeyName)
-    {
-      sourceDevice = device;
-    }
-
-    /// <summary>
-    /// Registers the actions for the messenger.
-    /// </summary>
-    protected override void RegisterActions()
-    {
-      base.RegisterActions();
-
-      AddAction("/fullStatus", (id, content) =>
-      {
-        var message = new CurrentSourcesStateMessage
-        {
-          CurrentSourceKeys = sourceDevice.CurrentSourceKeys,
-          CurrentSources = sourceDevice.CurrentSources
-        };
-
-        PostStatusMessage(message);
-      });
-
-      sourceDevice.CurrentSourcesChanged += (sender, e) =>
-      {
-        PostStatusMessage(JToken.FromObject(new
-        {
-          currentSourceKeys = sourceDevice.CurrentSourceKeys,
-          currentSources = sourceDevice.CurrentSources
-        }));
-      };
-    }
-  }
-
-  /// <summary>
-  /// Represents a CurrentSourcesStateMessage
-  /// </summary>
-  public class CurrentSourcesStateMessage : DeviceStateMessageBase
-  {
-
-    /// <summary>
-    /// Gets or sets the CurrentSourceKey
-    /// </summary>
-    [JsonProperty("currentSourceKey", NullValueHandling = NullValueHandling.Ignore)]
-    public Dictionary<eRoutingSignalType, string> CurrentSourceKeys { get; set; }
-
-
-    /// <summary>
-    /// Gets or sets the CurrentSource
-    /// </summary>
-    [JsonProperty("currentSource")]
-    public Dictionary<eRoutingSignalType, SourceListItem> CurrentSources { get; set; }
-  }
-}

src/PepperDash.Essentials.MobileControl.Messengers/Messengers/IHasCurrentSourceInfoMessenger.cs

@@ -54,18 +54,16 @@ namespace PepperDash.Essentials.AppServer.Messengers
     /// </summary>
     public class CurrentSourceStateMessage : DeviceStateMessageBase
     {
-
+        [JsonProperty("currentSourceKey", NullValueHandling = NullValueHandling.Ignore)]
         /// <summary>
         /// Gets or sets the CurrentSourceKey
         /// </summary>
-        [JsonProperty("currentSourceKey", NullValueHandling = NullValueHandling.Ignore)]
         public string CurrentSourceKey { get; set; }
 
-
+        [JsonProperty("currentSource")]
         /// <summary>
         /// Gets or sets the CurrentSource
         /// </summary>
-        [JsonProperty("currentSource")]
         public SourceListItem CurrentSource { get; set; }
     }
 }

src/PepperDash.Essentials.MobileControl/MobileControlSystemController.cs

@@ -1,10 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Reflection;
-using System.Text.RegularExpressions;
-using System.Threading.Tasks;
-using Crestron.SimplSharp;
+using Crestron.SimplSharp;
 using Crestron.SimplSharp.CrestronIO;
 using Crestron.SimplSharp.Net.Http;
 using Crestron.SimplSharp.WebScripting;
@@ -36,6 +30,12 @@ using PepperDash.Essentials.RoomBridges;
 using PepperDash.Essentials.Services;
 using PepperDash.Essentials.WebApiHandlers;
 using PepperDash.Essentials.WebSocketServer;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Reflection;
+using System.Text.RegularExpressions;
+using System.Threading.Tasks;
 using WebSocketSharp;
 
 namespace PepperDash.Essentials
@@ -582,7 +582,7 @@ namespace PepperDash.Essentials
                     {
                         this.LogVerbose(
                             "Adding ISetTopBoxControlMessenger for {deviceKey}"
-                        );
+                        );                        
 
                         var messenger = new ISetTopBoxControlsMessenger(
                             $"{device.Key}-stb-{Key}",
@@ -599,7 +599,7 @@ namespace PepperDash.Essentials
                     {
                         this.LogVerbose(
                             "Adding IChannelMessenger for {deviceKey}", device.Key
-                        );
+                        );                        
 
                         var messenger = new IChannelMessenger(
                             $"{device.Key}-channel-{Key}",
@@ -614,7 +614,7 @@ namespace PepperDash.Essentials
 
                     if (device is IColor colorDevice)
                     {
-                        this.LogVerbose("Adding IColorMessenger for {deviceKey}", device.Key);
+                        this.LogVerbose("Adding IColorMessenger for {deviceKey}", device.Key);                        
 
                         var messenger = new IColorMessenger(
                             $"{device.Key}-color-{Key}",
@@ -629,7 +629,7 @@ namespace PepperDash.Essentials
 
                     if (device is IDPad dPadDevice)
                     {
-                        this.LogVerbose("Adding IDPadMessenger for {deviceKey}", device.Key);
+                        this.LogVerbose("Adding IDPadMessenger for {deviceKey}", device.Key);                        
 
                         var messenger = new IDPadMessenger(
                             $"{device.Key}-dPad-{Key}",
@@ -644,7 +644,7 @@ namespace PepperDash.Essentials
 
                     if (device is INumericKeypad nkDevice)
                     {
-                        this.LogVerbose("Adding INumericKeyapdMessenger for {deviceKey}", device.Key);
+                        this.LogVerbose("Adding INumericKeyapdMessenger for {deviceKey}", device.Key);                        
 
                         var messenger = new INumericKeypadMessenger(
                             $"{device.Key}-numericKeypad-{Key}",
@@ -659,7 +659,7 @@ namespace PepperDash.Essentials
 
                     if (device is IHasPowerControl pcDevice)
                     {
-                        this.LogVerbose("Adding IHasPowerControlMessenger for {deviceKey}", device.Key);
+                        this.LogVerbose("Adding IHasPowerControlMessenger for {deviceKey}", device.Key);                        
 
                         var messenger = new IHasPowerMessenger(
                             $"{device.Key}-powerControl-{Key}",
@@ -693,7 +693,7 @@ namespace PepperDash.Essentials
                     {
                         this.LogVerbose(
                             "Adding ITransportMessenger for {deviceKey}", device.Key
-                        );
+                        );                        
 
                         var messenger = new ITransportMessenger(
                             $"{device.Key}-transport-{Key}",
@@ -721,17 +721,6 @@ namespace PepperDash.Essentials
                         messengerAdded = true;
                     }
 
-                    if (device is ICurrentSources currentSources)
-                    {
-                        this.LogVerbose("Adding CurrentSourcesMessenger for {deviceKey}", device.Key);
-
-                        var messenger = new CurrentSourcesMessenger($"{device.Key}-currentSources-{Key}", $"/device/{device.Key}", currentSources);
-
-                        AddDefaultDeviceMessenger(messenger);
-
-                        messengerAdded = true;
-                    }
-
                     if (device is ISwitchedOutput switchedDevice)
                     {
                         this.LogVerbose(
@@ -2320,7 +2309,7 @@ Mobile Control Direct Server Infromation:
                         {
                             this.LogInformation("-- Warning: Incoming message has no registered handler {type}", message.Type);
                             break;
-                        }
+                        }                        
 
                         foreach (var handler in handlers)
                         {