feat: rename IHasDestinationList to IHasDestinations for consistency

fix(hotfix): skip CrestronOnvif.dll during assembly scanning at startup

src/PepperDash.Essentials.Core/Bridges/BridgeBase.cs

@@ -30,6 +30,17 @@ namespace PepperDash.Essentials.Core.Bridges
         {
 
         }
+
+        /// <summary>
+        /// Constructor
+        /// </summary>
+        /// <param name="key"></param>
+        /// <param name="name"></param>
+        protected BridgeApi(string key, string name) :
+            base(key, name)
+        {
+
+        }
     }
 
     /// <summary>
@@ -58,7 +69,7 @@ namespace PepperDash.Essentials.Core.Bridges
         /// <param name="dc">Device configuration</param>
         /// <param name="eisc">EISC instance</param>
         public EiscApiAdvanced(DeviceConfig dc, BasicTriList eisc) :
-            base(dc.Key)
+            base(dc.Key, dc.Name)
         {
             JoinMaps = new Dictionary<string, JoinMapBaseAdvanced>();
 

src/PepperDash.Essentials.Core/Factory/DeviceFactory.cs

@@ -36,8 +36,17 @@ namespace PepperDash.Essentials.Core
         {
             var programAssemblies = Directory.GetFiles(InitialParametersClass.ProgramDirectory.ToString(), "*.dll");
 
+            // Assemblies known to cause load errors that should be skipped
+            var assembliesToSkip = new[] { "CrestronOnvif.dll" };
+
             foreach (var assembly in programAssemblies)
             {
+                if (assembliesToSkip.Any(a => Path.GetFileName(assembly).Equals(a, StringComparison.OrdinalIgnoreCase)))
+                {
+                    Debug.LogMessage(LogEventLevel.Verbose, "Skipping assembly: {assemblyName}", Path.GetFileName(assembly));
+                    continue;
+                }
+
                 try
                 {
                     Assembly.LoadFrom(assembly);

src/PepperDash.Essentials.Core/Room/IHasDestinationList.cs

@@ -0,0 +1,16 @@
+using System.Collections.Generic;
+
+namespace PepperDash.Essentials.Core
+{
+
+    /// <summary>
+    /// Interface for rooms with a list of destinations
+    /// </summary>
+    public interface IHasDestinations
+    {
+        /// <summary>
+        /// Gets the dictionary of destinations.
+        /// </summary>
+        Dictionary<string, IRoutingSink> Destinations { get; }
+    }
+}

src/PepperDash.Essentials.Core/Room/IHasSourceList.cs

@@ -0,0 +1,15 @@
+using System.Collections.Generic;
+namespace PepperDash.Essentials.Core
+{
+
+    /// <summary>
+    /// Interface for rooms with a list of destinations
+    /// </summary>
+    public interface IHasSourceList
+    {
+        /// <summary>
+        /// Gets the list of sources.
+        /// </summary>
+        Dictionary<string, SourceListItem> SourceList { get; }
+    }
+}

src/PepperDash.Essentials.Core/Routing/RoutingFeedbackManager.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using PepperDash.Core;
 using PepperDash.Essentials.Core.Config;
@@ -230,6 +231,15 @@ namespace PepperDash.Essentials.Core.Routing
                             return roomDefaultDisplay.DefaultDisplay.Key == destination.Key;
                         }
 
+                        if (r is IHasDestinationList roomDestinationList)
+                        {
+                            return roomDestinationList.Destinations.Any(d =>
+                                d.Value.Key == destination.Key
+                            );
+                        }
+
+                        var destList = ConfigReader.ConfigObject.GetDestinationListForKey(r.DestinationListKey);
+
                         return false;
                     }
                 );
@@ -245,9 +255,17 @@ namespace PepperDash.Essentials.Core.Routing
                 return;
             }
 
-            // Debug.LogMessage(Serilog.Events.LogEventLevel.Verbose, "Found room {room} for destination {destination}", this, room.Key, destination.Key);
+            Debug.LogMessage(Serilog.Events.LogEventLevel.Verbose, "Found room {room} for destination {destination}", this, room.Key, destination.Key);
 
-            var sourceList = ConfigReader.ConfigObject.GetSourceListForKey(room.SourceListKey);
+            Dictionary<string, SourceListItem> sourceList = null;
+
+            if (room is IHasSourceList roomWithSourceList)
+            {
+                sourceList = roomWithSourceList.SourceList;
+            }
+            else {
+                 sourceList = ConfigReader.ConfigObject.GetSourceListForKey(room.SourceListKey);
+            }   
 
             if (sourceList == null)
             {