Fix thread-safety issue in GetRouteToSource - snapshot TieLineCollection before enumeration

Co-authored-by: ngenovese11 <23391587+ngenovese11@users.noreply.github.com>

src/PepperDash.Essentials.Core/Bridges/BridgeBase.cs

@@ -30,6 +30,17 @@ namespace PepperDash.Essentials.Core.Bridges
         {
 
         }
+
+        /// <summary>
+        /// Constructor
+        /// </summary>
+        /// <param name="key"></param>
+        /// <param name="name"></param>
+        protected BridgeApi(string key, string name) :
+            base(key, name)
+        {
+
+        }
     }
 
     /// <summary>
@@ -58,7 +69,7 @@ namespace PepperDash.Essentials.Core.Bridges
         /// <param name="dc">Device configuration</param>
         /// <param name="eisc">EISC instance</param>
         public EiscApiAdvanced(DeviceConfig dc, BasicTriList eisc) :
-            base(dc.Key)
+            base(dc.Key, dc.Name)
         {
             JoinMaps = new Dictionary<string, JoinMapBaseAdvanced>();
 

src/PepperDash.Essentials.Core/Factory/DeviceFactory.cs

@@ -36,8 +36,17 @@ namespace PepperDash.Essentials.Core
         {
             var programAssemblies = Directory.GetFiles(InitialParametersClass.ProgramDirectory.ToString(), "*.dll");
 
+            // Assemblies known to cause load errors that should be skipped
+            var assembliesToSkip = new[] { "CrestronOnvif.dll" };
+
             foreach (var assembly in programAssemblies)
             {
+                if (assembliesToSkip.Any(a => Path.GetFileName(assembly).Equals(a, StringComparison.OrdinalIgnoreCase)))
+                {
+                    Debug.LogMessage(LogEventLevel.Verbose, "Skipping assembly: {assemblyName}", Path.GetFileName(assembly));
+                    continue;
+                }
+
                 try
                 {
                     Assembly.LoadFrom(assembly);

src/PepperDash.Essentials.Core/Routing/Extensions.cs

@@ -339,17 +339,21 @@ namespace PepperDash.Essentials.Core
 
             RoutingInputPort goodInputPort = null;
 
+            // Take a snapshot to avoid InvalidOperationException if TieLineCollection.Default is
+            // modified concurrently (e.g. NVX tie line registration during route requests).
+            var tieLines = TieLineCollection.Default.ToList();
+
             IEnumerable<TieLine> destinationTieLines;
             TieLine directTie = null;
 
             if (destinationPort == null)
             {
-                destinationTieLines = TieLineCollection.Default.Where(t =>
+                destinationTieLines = tieLines.Where(t =>
                     t.DestinationPort.ParentDevice.Key == destination.Key && (t.Type.HasFlag(signalType) || signalType == eRoutingSignalType.AudioVideo));
             }
             else
             {
-                destinationTieLines = TieLineCollection.Default.Where(t => t.DestinationPort.ParentDevice.Key == destination.Key && t.DestinationPort.Key == destinationPort.Key && (t.Type.HasFlag(signalType)));
+                destinationTieLines = tieLines.Where(t => t.DestinationPort.ParentDevice.Key == destination.Key && t.DestinationPort.Key == destinationPort.Key && (t.Type.HasFlag(signalType)));
             }
 
             // find the TieLine without a port