Merge pull request #51 from PepperDash/hotfix/ssh-issues

Hotfix/ssh issues

.github/workflows/docker.yml

@@ -144,10 +144,14 @@ jobs:
         uses: nuget/setup-nuget@v1
       - name: Add Github Packages source
         run: nuget sources add -name github -source https://nuget.pkg.github.com/pepperdash/index.json -username Pepperdash -password ${{ secrets.GITHUB_TOKEN }}
+      - name: Add nuget.org API Key
+        run: nuget setApiKey ${{ secrets.NUGET_API_KEY }}
       - name: Create nuget package
         run: nuget pack "./PepperDash_Core.nuspec" -version ${{ env.VERSION }}
       - name: Publish nuget package to Github registry
         run: nuget push **/*.nupkg -source github
+      - name: Publish nuget package to nuget.org
+        run: nuget push **/*.nupkg -Source https://api.nuget.org/v3/index.json
   # This step always runs and pushes the build to the internal build rep
   Internal_Push_Output:
     needs: Build_Project

.github/workflows/main.yml

@@ -119,10 +119,14 @@ jobs:
         uses: nuget/setup-nuget@v1
       - name: Add Github Packages source
         run: nuget sources add -name github -source https://nuget.pkg.github.com/pepperdash/index.json -username Pepperdash -password ${{ secrets.GITHUB_TOKEN }}
+      - name: Add nuget.org API Key
+        run: nuget setApiKey ${{ secrets.NUGET_API_KEY }}
       - name: Create nuget package
         run: nuget pack "./PepperDash_Core.nuspec" -version ${{ env.VERSION }}
       - name: Publish nuget package to Github registry
         run: nuget push **/*.nupkg -source github
+      - name: Publish nuget package to nuget.org
+        run: nuget push **/*.nupkg -Source https://api.nuget.org/v3/index.json
   Internal_Push_Output:
     needs: Build_Project
     runs-on: windows-latest

Pepperdash Core/Pepperdash Core/Comm/GenericSshClient.cs

@@ -13,6 +13,7 @@ namespace PepperDash.Core
 	/// </summary>
     public class GenericSshClient : Device, ISocketStatusWithStreamDebugging, IAutoReconnect
 	{
+	    private const string SPlusKey = "Uninitialized SshClient";
         public CommunicationStreamDebugging StreamDebugging { get; private set; }
 
 		/// <summary>
@@ -155,8 +156,9 @@ namespace PepperDash.Core
 		/// S+ Constructor - Must set all properties before calling Connect
 		/// </summary>
 		public GenericSshClient()
-			: base("Uninitialized SshClient")
+			: base(SPlusKey)
 		{
+            StreamDebugging = new CommunicationStreamDebugging(SPlusKey);
 			CrestronEnvironment.ProgramStatusEventHandler += new ProgramStatusEventHandler(CrestronEnvironment_ProgramStatusEventHandler);
 			AutoReconnectIntervalMs = 5000;
 		}
@@ -243,7 +245,7 @@ namespace PepperDash.Core
             try
             {
                 Client.Connect();
-                TheStream = Client.CreateShellStream("PDTShell", 100, 80, 100, 200, 100000);
+                TheStream = Client.CreateShellStream("PDTShell", 100, 80, 100, 200, 65534);
                 TheStream.DataReceived += Stream_DataReceived;
                 //TheStream.ErrorOccurred += TheStream_ErrorOccurred;
                 Debug.Console(1, this, "Connected");
@@ -437,8 +439,11 @@ namespace PepperDash.Core
 
                 }
 			}
-			catch
+			catch (Exception ex)
 			{
+			    Debug.Console(0, "Exception: {0}", ex.Message);
+			    Debug.Console(0, "Stack Trace: {0}", ex.StackTrace);
+
 				Debug.Console(1, this, "Stream write failed. Disconnected, closing");
 				ClientStatus = SocketStatus.SOCKET_STATUS_BROKEN_REMOTELY;
 				HandleConnectionFailure();

Pepperdash Core/Pepperdash Core/Comm/GenericTcpIpClient.cs

@@ -15,7 +15,8 @@ namespace PepperDash.Core
     /// A class to handle basic TCP/IP communications with a server
     /// </summary>
 	public class GenericTcpIpClient : Device, ISocketStatusWithStreamDebugging, IAutoReconnect
-	{
+    {
+        private const string SplusKey = "Uninitialized TcpIpClient";
         public CommunicationStreamDebugging StreamDebugging { get; private set; }
 
 		/// <summary>
@@ -204,8 +205,9 @@ namespace PepperDash.Core
         /// Default constructor for S+
         /// </summary>
         public GenericTcpIpClient()
-			: base("Uninitialized TcpIpClient")
+			: base(SplusKey)
 		{
+            StreamDebugging = new CommunicationStreamDebugging(SplusKey);
 			CrestronEnvironment.ProgramStatusEventHandler += new ProgramStatusEventHandler(CrestronEnvironment_ProgramStatusEventHandler);
 			AutoReconnectIntervalMs = 5000;
             BufferSize = 2000;

Pepperdash Core/Pepperdash Core/Comm/GenericUdpServer.cs

@@ -17,6 +17,7 @@ namespace PepperDash.Core
 {
     public class GenericUdpServer : Device, ISocketStatusWithStreamDebugging
     {
+        private const string SplusKey = "Uninitialized Udp Server";
         public CommunicationStreamDebugging StreamDebugging { get; private set; }
         /// <summary>
         /// 
@@ -119,8 +120,9 @@ namespace PepperDash.Core
         /// Constructor for S+. Make sure to set key, address, port, and buffersize using init method
         /// </summary>
         public GenericUdpServer()
-            : base("Uninitialized Udp Server")
+            : base(SplusKey)
         {
+            StreamDebugging = new CommunicationStreamDebugging(SplusKey);
             BufferSize = 5000;
             DequeueLock = new CCriticalSection();
             MessageQueue = new CrestronQueue<GenericUdpReceiveTextExtraArgs>();

Readme.md

@@ -1,5 +1,7 @@
 # PepperDash Core (c) 2020
 
+## [Latest Release](https://github.com/PepperDash/PepperDashCore/releases/latest)
+
 ## License
 Provided under MIT license